While translating, I noticed there is a typo in the description of the manage_staged_records permission. All other permission descriptions are in the present tense, but this one is in the past tense. Managed staged MARC records, including completing and reversing imports (manage_staged_marc) For example, compared to Stage MARC records into the reservoir (stage_marc_import) To recreate: 1. Go to any patron record 2. Click More > Set permissions 3. Click Show details next to the Use all tools permission --> Notice all descriptions start with a present tense verb except Managed staged MARC records A simple slip of the finger!
Created attachment 154340 [details] [review] Bug 34511: Typo in manage_staged_records permission description This patch corrects a typo in the description of the manage_staged_records permission. All other permission descriptions are in the present tense, but this one is in the past tense. To test: 0. Apply the patch 1. Go to any patron record 2. Click More > Set permissions 3. Click Show details next to the Use all tools permission 4. Read the description for the manage_staged_records permission, make sure the spelling and grammar are correct
Created attachment 154345 [details] [review] Bug 34511: Typo in manage_staged_records permission description This patch corrects a typo in the description of the manage_staged_records permission. All other permission descriptions are in the present tense, but this one is in the past tense. To test: 0. Apply the patch 1. Go to any patron record 2. Click More > Set permissions 3. Click Show details next to the Use all tools permission 4. Read the description for the manage_staged_records permission, make sure the spelling and grammar are correct Signed-off-by: hebah <hebah@bywatersolutions.com>
Typo fixed!
Created attachment 156373 [details] [review] Bug 34511: Typo in manage_staged_records permission description This patch corrects a typo in the description of the manage_staged_records permission. All other permission descriptions are in the present tense, but this one is in the past tense. To test: 0. Apply the patch 1. Go to any patron record 2. Click More > Set permissions 3. Click Show details next to the Use all tools permission 4. Read the description for the manage_staged_records permission, make sure the spelling and grammar are correct Signed-off-by: hebah <hebah@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Just thinking whether reversing should be reverting actually in the same sentence? No blocker.
Pushed to master for 23.11. Nice work everyone, thanks!
Makes more sens, I choose to backport Pushed to 23.05.x for 23.05.05
Nice work everyone! Pushed to oldstable for 22.11.x