Bug 34518 - "Renew all" button doesn't work in OPAC
Summary: "Renew all" button doesn't work in OPAC
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Pedro Amorim
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 31735
Blocks:
  Show dependency treegraph
 
Reported: 2023-08-11 13:07 UTC by Pedro Amorim
Modified: 2024-07-04 20:37 UTC (History)
9 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.04
Circulation function:


Attachments
Bug 34518: Fix 'Renew all' button in OPAC (1.57 KB, patch)
2023-08-11 13:08 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 34518: Fix 'Renew all' button in OPAC (1.63 KB, patch)
2023-08-14 16:40 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 34518: Fix 'Renew all' button in OPAC (1.68 KB, patch)
2023-08-24 21:15 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2023-08-11 13:07:35 UTC
I believe this regression was introduced in patch "Bug 31735: Optimize OPAC checkouts view".

To reproduce, on k-t-d:
- Checkout an item to koha user (42)
- Log-in to OPAC and visit user summary to see check-outs
- Press 'Renew all' button at the bottom, notice it doesn't work.
Comment 1 Pedro Amorim 2023-08-11 13:08:57 UTC
Created attachment 154369 [details] [review]
Bug 34518: Fix 'Renew all' button in OPAC

Test plan:
- Checkout an item to koha user (42)
- Log-in to OPAC and visit user summary to see check-outs
- Press 'Renew all' button at the bottom, notice it doesn't work.
- Apply patch. Repeat and verify it now works
Comment 2 Lucas Gass (lukeg) 2023-08-14 16:40:12 UTC
Created attachment 154412 [details] [review]
Bug 34518: Fix 'Renew all' button in OPAC

Test plan:
- Checkout an item to koha user (42)
- Log-in to OPAC and visit user summary to see check-outs
- Press 'Renew all' button at the bottom, notice it doesn't work.
- Apply patch. Repeat and verify it now works

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Katrin Fischer 2023-08-24 21:15:26 UTC
Created attachment 154755 [details] [review]
Bug 34518: Fix 'Renew all' button in OPAC

Test plan:
- Checkout an item to koha user (42)
- Log-in to OPAC and visit user summary to see check-outs
- Press 'Renew all' button at the bottom, notice it doesn't work.
- Apply patch. Repeat and verify it now works

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-08-29 17:36:37 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-08-29 21:41:52 UTC
Pushed to 23.05.x for 23.05.04
Comment 6 Matt Blenkinsop 2023-08-31 09:49:42 UTC
Dpendency 31375 is missing in 22.11.x - not backporting.

Nice work everyone!