Observed in 22.11 To recreate: Log into OPAC as patron of Branch A Make purchase suggestion for Branch B Refresh /cgi-bin/koha/opac-suggestions.pl and see that suggestion appears to have been made for Branch A View suggestion from staff client See that it accurately reflects suggestion having been made for Branch B This display is confusing (and inaccurate) for patrons.
The column that displays inaccurately is "Suggested for" which requires the system preference OPACViewOthersSuggestions to be turned on.
Created attachment 154393 [details] [review] Bug 34522: Pass the suggestion branchcode, not the suggeter branchcode To test: 1. Turn on OPACViewOthersSuggestions 2. Log into OPAC as patron of Branch A 3. Make purchase suggestion for Branch B 4. Refresh /cgi-bin/koha/opac-suggestions.pl and see that suggestion appears to have been made for Branch A 5. View suggestion from staff client - See that it accurately reflects suggestion having been made for Branch B 6. Apply patch and try steps 2 - 5 again, this time you should see the proper branch.
Testing this one right now!
Created attachment 154496 [details] [review] Bug 34522: Pass the suggestion branchcode, not the suggeter branchcode To test: 1. Turn on OPACViewOthersSuggestions 2. Log into OPAC as patron of Branch A 3. Make purchase suggestion for Branch B 4. Refresh /cgi-bin/koha/opac-suggestions.pl and see that suggestion appears to have been made for Branch A 5. View suggestion from staff client - See that it accurately reflects suggestion having been made for Branch B 6. Apply patch and try steps 2 - 5 again, this time you should see the proper branch. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
If we could get another sign-off here, I could use mine for QA :)
Created attachment 154798 [details] [review] Bug 34522: Pass the suggestion branchcode, not the suggeter branchcode To test: 1. Turn on OPACViewOthersSuggestions 2. Log into OPAC as patron of Branch A 3. Make purchase suggestion for Branch B 4. Refresh /cgi-bin/koha/opac-suggestions.pl and see that suggestion appears to have been made for Branch A 5. View suggestion from staff client - See that it accurately reflects suggestion having been made for Branch B 6. Apply patch and try steps 2 - 5 again, this time you should see the proper branch. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: David Nind <david@davidnind.com>
Thanks David, switching this to PQA with my SO converted to QA :)
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.04
Nice work everyone! Pushed to oldstable for 22.11.x