Bug 34529 - Offline circulation should be able to accept userid as well as cardnumber
Summary: Offline circulation should be able to accept userid as well as cardnumber
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-14 14:34 UTC by Kyle M Hall
Modified: 2023-11-10 07:50 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34529: Offline circulation should be able to accept userid as well as cardnumber (2.53 KB, patch)
2023-08-14 14:58 UTC, Kyle M Hall
Details | Diff | Splinter Review
test.koc (150 bytes, text/plain)
2023-08-14 16:11 UTC, Kyle M Hall
Details
Bug 34529: Offline circulation should be able to accept userid as well as cardnumber (2.53 KB, patch)
2023-09-21 09:17 UTC, Philip Orr
Details | Diff | Splinter Review
Bug 34529: Offline circulation should be able to accept userid as well as cardnumber (2.58 KB, patch)
2023-09-21 09:18 UTC, Philip Orr
Details | Diff | Splinter Review
Bug 34529: Offline circulation should be able to accept userid as well as cardnumber (2.58 KB, patch)
2023-10-31 15:48 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 34529: (QA follow-up) Update column heading to "Card number or username" (1.13 KB, patch)
2023-10-31 15:48 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 34529: Offline circulation should be able to accept userid as well as cardnumber (2.64 KB, patch)
2023-11-03 10:49 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 34529: (QA follow-up) Update column heading to "Card number or username" (1.19 KB, patch)
2023-11-03 10:50 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 34529: (QA follow-up) Add unit tests (2.67 KB, patch)
2023-11-03 10:50 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 34529: (QA follow-up) Tidy OfflineCirculation.t (5.64 KB, patch)
2023-11-03 10:50 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 34529: Offline circulation should be able to accept userid as well as cardnumber (2.69 KB, patch)
2023-11-04 13:11 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 34529: (QA follow-up) Update column heading to "Card number or username" (1.24 KB, patch)
2023-11-04 13:11 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 34529: (QA follow-up) Add unit tests (2.72 KB, patch)
2023-11-04 13:11 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 34529: (QA follow-up) Tidy OfflineCirculation.t (5.69 KB, patch)
2023-11-04 13:11 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2023-08-14 14:34:09 UTC
Like everywhere else in Koha, offline circulation should be able to use userid as well as cardnumber to look up the patron for a transaction ( checkouts and fine payments ).
Comment 1 Kyle M Hall 2023-08-14 14:58:07 UTC
Created attachment 154403 [details] [review]
Bug 34529: Offline circulation should be able to accept userid as well as cardnumber

Like everywhere else in Koha, offline circulation should be able to use userid as well as cardnumber to look up the patron for a transaction ( checkouts and fine payments ).

Test Plan:
1) Apply this patch
2) Restart all the things!
3) Download the test.koc file attached to this bug
4) Verify you have an item with the barcode 39999000001396
   create it if needed
5) Set a patron's username to "hacevedo"
6) Upload and import the test.koc file into offline circ
7) Verify the item was checked out and the payment was made
Comment 2 Kyle M Hall 2023-08-14 16:11:29 UTC
Created attachment 154411 [details]
test.koc
Comment 3 Philip Orr 2023-09-21 09:17:26 UTC
Created attachment 155969 [details] [review]
Bug 34529: Offline circulation should be able to accept userid as well as cardnumber

Like everywhere else in Koha, offline circulation should be able to use userid as well as cardnumber to look up the patron for a transaction ( checkouts and fine payments ).

Test Plan:
1) Apply this patch
2) Restart all the things!
3) Download the test.koc file attached to this bug
4) Verify you have an item with the barcode 39999000001396
   create it if needed
5) Set a patron's username to "hacevedo"
6) Upload and import the test.koc file into offline circ
7) Verify the item was checked out and the payment was made
Comment 4 Philip Orr 2023-09-21 09:18:34 UTC
Created attachment 155970 [details] [review]
Bug 34529: Offline circulation should be able to accept userid as well as cardnumber

Like everywhere else in Koha, offline circulation should be able to use userid as well as cardnumber to look up the patron for a transaction ( checkouts and fine payments ).

Test Plan:
1) Apply this patch
2) Restart all the things!
3) Download the test.koc file attached to this bug
4) Verify you have an item with the barcode 39999000001396
   create it if needed
5) Set a patron's username to "hacevedo"
6) Upload and import the test.koc file into offline circ
7) Verify the item was checked out and the payment was made

Signed-off-by: Philip Orr <philip.orr@lmscloud.de>
Comment 5 Philip Orr 2023-09-21 09:19:21 UTC
oops, forgot to signoff before attaching. Sorry!
Comment 6 Katrin Fischer 2023-10-31 15:48:47 UTC
Created attachment 158140 [details] [review]
Bug 34529: Offline circulation should be able to accept userid as well as cardnumber

Like everywhere else in Koha, offline circulation should be able to use userid as well as cardnumber to look up the patron for a transaction ( checkouts and fine payments ).

Test Plan:
1) Apply this patch
2) Restart all the things!
3) Download the test.koc file attached to this bug
4) Verify you have an item with the barcode 39999000001396
   create it if needed
5) Set a patron's username to "hacevedo"
6) Upload and import the test.koc file into offline circ
7) Verify the item was checked out and the payment was made

Signed-off-by: Philip Orr <philip.orr@lmscloud.de>
Comment 7 Katrin Fischer 2023-10-31 15:48:50 UTC
Created attachment 158141 [details] [review]
Bug 34529: (QA follow-up) Update column heading to "Card number or username"

Updates the column heading on the table of uploaded transactions
to read "Card number or username".
Comment 8 Katrin Fischer 2023-10-31 15:49:28 UTC
Hi Kyle, this looks good so far, but we are missing unit tests for the changes in Circulation. Please also check my small follow-up.
Comment 9 Kyle M Hall 2023-11-03 10:49:59 UTC
Created attachment 158321 [details] [review]
Bug 34529: Offline circulation should be able to accept userid as well as cardnumber

Like everywhere else in Koha, offline circulation should be able to use userid as well as cardnumber to look up the patron for a transaction ( checkouts and fine payments ).

Test Plan:
1) Apply this patch
2) Restart all the things!
3) Download the test.koc file attached to this bug
4) Verify you have an item with the barcode 39999000001396
   create it if needed
5) Set a patron's username to "hacevedo"
6) Upload and import the test.koc file into offline circ
7) Verify the item was checked out and the payment was made

Signed-off-by: Philip Orr <philip.orr@lmscloud.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 10 Kyle M Hall 2023-11-03 10:50:07 UTC
Created attachment 158322 [details] [review]
Bug 34529: (QA follow-up) Update column heading to "Card number or username"

Updates the column heading on the table of uploaded transactions
to read "Card number or username".

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 11 Kyle M Hall 2023-11-03 10:50:09 UTC
Created attachment 158323 [details] [review]
Bug 34529: (QA follow-up) Add unit tests

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 12 Kyle M Hall 2023-11-03 10:50:11 UTC
Created attachment 158324 [details] [review]
Bug 34529: (QA follow-up) Tidy OfflineCirculation.t

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 13 Katrin Fischer 2023-11-04 13:11:23 UTC
Created attachment 158380 [details] [review]
Bug 34529: Offline circulation should be able to accept userid as well as cardnumber

Like everywhere else in Koha, offline circulation should be able to use userid as well as cardnumber to look up the patron for a transaction ( checkouts and fine payments ).

Test Plan:
1) Apply this patch
2) Restart all the things!
3) Download the test.koc file attached to this bug
4) Verify you have an item with the barcode 39999000001396
   create it if needed
5) Set a patron's username to "hacevedo"
6) Upload and import the test.koc file into offline circ
7) Verify the item was checked out and the payment was made

Signed-off-by: Philip Orr <philip.orr@lmscloud.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 14 Katrin Fischer 2023-11-04 13:11:27 UTC
Created attachment 158381 [details] [review]
Bug 34529: (QA follow-up) Update column heading to "Card number or username"

Updates the column heading on the table of uploaded transactions
to read "Card number or username".

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 15 Katrin Fischer 2023-11-04 13:11:29 UTC
Created attachment 158382 [details] [review]
Bug 34529: (QA follow-up) Add unit tests

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 16 Katrin Fischer 2023-11-04 13:11:33 UTC
Created attachment 158383 [details] [review]
Bug 34529: (QA follow-up) Tidy OfflineCirculation.t

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 17 Tomás Cohen Arazi 2023-11-06 14:36:46 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 18 Fridolin Somers 2023-11-10 07:50:31 UTC
Enhancement not pushed to 23.05.x