It would be nice for the reason for branch transfers (branchtransfers.reason) to be a configurable column on returns.pl, so libraries know which checkins may need more attention in the case of a dismissed modal or receipt printing issue.
Created attachment 154470 [details] [review] Bug 34547: Add transfer reason to checkedintable on returns.tt To test: 1. Apply patch, restart_all 2. Check some items out and prepare some reasons that would initiate a branchtransfer. According the schema it can be any of the following: 'Manual', 'StockrotationAdvance', 'StockrotationRepatriation', 'ReturnToHome', 'ReturnToHolding', 'RotatingCollection', 'Reserve', 'LostReserve', 'CancelReserve', 'TransferCancellation', 'Recall', 'RecallCancellation. 3. CHeck in some the items and notice the 'Transfer reason' column in the table. Make sure the reasons are acurate and make sense. 4. To go Table settings and find the 'checkedintable'. Make sure you can properly hide the column from the display.
Tried to apply the patch in a Bywater sandbox and got this error: Error getting login cookie from browser: Cannot find default Firefox profile Configured browser: firefox3 (change with 'git config --global bz.browser <value>') Possible browsers: chromium, epiphany, firefox3, galeon, google-chrome I tried using both Forefox and Chrome and got the same error. Tried the bug anyway but could not see the changes in the table or in the settings.
Created attachment 154592 [details] [review] Bug 34547: Add transfer reason to checkedintable on returns.tt To test: 1. Apply patch, restart_all 2. Check some items out and prepare some reasons that would initiate a branchtransfer. According the schema it can be any of the following: 'Manual', 'StockrotationAdvance', 'StockrotationRepatriation', 'ReturnToHome', 'ReturnToHolding', 'RotatingCollection', 'Reserve', 'LostReserve', 'CancelReserve', 'TransferCancellation', 'Recall', 'RecallCancellation. 3. CHeck in some the items and notice the 'Transfer reason' column in the table. Make sure the reasons are acurate and make sense. 4. To go Table settings and find the 'checkedintable'. Make sure you can properly hide the column from the display. Signed-off-by: AndrewA <andrew.auld@ptfs-europe.com>
Yay! All works perfectly, thanks.
Looks good except that the switch statement in returns.tt is missing options for Recall and RecallCancellation.
Created attachment 156243 [details] [review] Bug 34547: (follow-up) add recall cases
(In reply to Emily Lamancusa from comment #5) > Looks good except that the switch statement in returns.tt is missing options > for Recall and RecallCancellation. Good catch. Please check the wording I am using for Recall and RecallCancellation to make sure it makes sense.
Created attachment 156296 [details] [review] Bug 34547: Add transfer reason to checkedintable on returns.tt To test: 1. Apply patch, restart_all 2. Check some items out and prepare some reasons that would initiate a branchtransfer. According the schema it can be any of the following: 'Manual', 'StockrotationAdvance', 'StockrotationRepatriation', 'ReturnToHome', 'ReturnToHolding', 'RotatingCollection', 'Reserve', 'LostReserve', 'CancelReserve', 'TransferCancellation', 'Recall', 'RecallCancellation. 3. CHeck in some the items and notice the 'Transfer reason' column in the table. Make sure the reasons are acurate and make sense. 4. To go Table settings and find the 'checkedintable'. Make sure you can properly hide the column from the display. Signed-off-by: AndrewA <andrew.auld@ptfs-europe.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Created attachment 156297 [details] [review] Bug 34547: (follow-up) add recall cases Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
The wording makes sense to me, and even better it mirrors the wording for Hold and HoldCancellation. I made a trivial amendment to the follow-up patch - the first follow-up fixed the modal, but not the table row. It was a two-line, copy/paste string change, so I just added it to the original follow-up and passed QA.
Pushed to master for 23.11. Nice work everyone, thanks!
Enhancement not pushed to 23.05.x