Bug 34547 - Add transfer reason to list of checkins
Summary: Add transfer reason to list of checkins
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Lucas Gass
QA Contact: Emily Lamancusa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-16 20:48 UTC by hebah
Modified: 2023-10-25 22:18 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34547: Add transfer reason to checkedintable on returns.tt (4.89 KB, patch)
2023-08-16 21:24 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 34547: Add transfer reason to checkedintable on returns.tt (4.94 KB, patch)
2023-08-18 08:05 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 34547: (follow-up) add recall cases (1.27 KB, patch)
2023-09-26 20:12 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 34547: Add transfer reason to checkedintable on returns.tt (5.01 KB, patch)
2023-09-27 14:54 UTC, Emily Lamancusa
Details | Diff | Splinter Review
Bug 34547: (follow-up) add recall cases (2.10 KB, patch)
2023-09-27 14:54 UTC, Emily Lamancusa
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description hebah 2023-08-16 20:48:19 UTC
It would be nice for the reason for branch transfers (branchtransfers.reason) to be a configurable column on returns.pl, so libraries know which checkins may need more attention in the case of a dismissed modal or receipt printing issue.
Comment 1 Lucas Gass 2023-08-16 21:24:10 UTC
Created attachment 154470 [details] [review]
Bug 34547: Add transfer reason to checkedintable on returns.tt

To test:
1. Apply patch, restart_all
2. Check some items out and prepare some reasons that would initiate a branchtransfer. According the schema it can be any of the following: 'Manual', 'StockrotationAdvance', 'StockrotationRepatriation', 'ReturnToHome', 'ReturnToHolding', 'RotatingCollection', 'Reserve', 'LostReserve', 'CancelReserve', 'TransferCancellation', 'Recall', 'RecallCancellation.
3. CHeck in some the items and notice the 'Transfer reason' column in the table. Make sure the reasons are acurate and make sense.
4. To go Table settings and find the 'checkedintable'. Make sure you can properly hide the column from the display.
Comment 2 Stina Hallin 2023-08-17 08:43:16 UTC
Tried to apply the patch in a Bywater sandbox and got this error:
Error getting login cookie from browser:
   Cannot find default Firefox profile

Configured browser: firefox3 (change with 'git config --global bz.browser <value>')
Possible browsers: chromium, epiphany, firefox3, galeon, google-chrome

I tried using both Forefox and Chrome and got the same error. Tried the bug anyway but could not see the changes in the table or in the settings.
Comment 3 ByWater Sandboxes 2023-08-18 08:05:43 UTC
Created attachment 154592 [details] [review]
Bug 34547: Add transfer reason to checkedintable on returns.tt

To test:
1. Apply patch, restart_all
2. Check some items out and prepare some reasons that would initiate a branchtransfer. According the schema it can be any of the following: 'Manual', 'StockrotationAdvance', 'StockrotationRepatriation', 'ReturnToHome', 'ReturnToHolding', 'RotatingCollection', 'Reserve', 'LostReserve', 'CancelReserve', 'TransferCancellation', 'Recall', 'RecallCancellation.
3. CHeck in some the items and notice the 'Transfer reason' column in the table. Make sure the reasons are acurate and make sense.
4. To go Table settings and find the 'checkedintable'. Make sure you can properly hide the column from the display.

Signed-off-by: AndrewA <andrew.auld@ptfs-europe.com>
Comment 4 Andrew Auld 2023-08-18 08:06:15 UTC
Yay! All works perfectly, thanks.
Comment 5 Emily Lamancusa 2023-09-26 19:27:05 UTC
Looks good except that the switch statement in returns.tt is missing options for Recall and RecallCancellation.
Comment 6 Lucas Gass 2023-09-26 20:12:09 UTC
Created attachment 156243 [details] [review]
Bug 34547: (follow-up) add recall cases
Comment 7 Lucas Gass 2023-09-26 20:13:06 UTC
(In reply to Emily Lamancusa from comment #5)
> Looks good except that the switch statement in returns.tt is missing options
> for Recall and RecallCancellation.

Good catch. Please check the wording I am using for Recall and RecallCancellation to make sure it makes sense.
Comment 8 Emily Lamancusa 2023-09-27 14:54:35 UTC
Created attachment 156296 [details] [review]
Bug 34547: Add transfer reason to checkedintable on returns.tt

To test:
1. Apply patch, restart_all
2. Check some items out and prepare some reasons that would initiate a branchtransfer. According the schema it can be any of the following: 'Manual', 'StockrotationAdvance', 'StockrotationRepatriation', 'ReturnToHome', 'ReturnToHolding', 'RotatingCollection', 'Reserve', 'LostReserve', 'CancelReserve', 'TransferCancellation', 'Recall', 'RecallCancellation.
3. CHeck in some the items and notice the 'Transfer reason' column in the table. Make sure the reasons are acurate and make sense.
4. To go Table settings and find the 'checkedintable'. Make sure you can properly hide the column from the display.

Signed-off-by: AndrewA <andrew.auld@ptfs-europe.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 9 Emily Lamancusa 2023-09-27 14:54:37 UTC
Created attachment 156297 [details] [review]
Bug 34547: (follow-up) add recall cases

Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 10 Emily Lamancusa 2023-09-27 15:01:16 UTC
The wording makes sense to me, and even better it mirrors the wording for Hold and HoldCancellation.

I made a trivial amendment to the follow-up patch - the first follow-up fixed the modal, but not the table row. It was a two-line, copy/paste string change, so I just added it to the original follow-up and passed QA.
Comment 11 Tomás Cohen Arazi 2023-10-20 14:48:40 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 12 Fridolin Somers 2023-10-25 22:18:01 UTC
Enhancement not pushed to 23.05.x