Bug 34558 - Update custom.sql for it-IT webinstaller
Summary: Update custom.sql for it-IT webinstaller
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (web-based installer) (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Zeno Tajoli
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-17 08:44 UTC by Zeno Tajoli
Modified: 2023-10-17 17:36 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.05,22.11.11


Attachments
Image of the bug (17.65 KB, image/png)
2023-08-17 09:01 UTC, Zeno Tajoli
Details
patch for custom.sql (3.78 KB, patch)
2023-08-17 12:11 UTC, Zeno Tajoli
Details | Diff | Splinter Review
patch for custom.sql (4.16 KB, patch)
2023-10-04 20:22 UTC, Zeno Tajoli
Details | Diff | Splinter Review
Bug 34558: Update custom.sql for it-IT webinstaller (4.15 KB, patch)
2023-10-05 17:09 UTC, David Nind
Details | Diff | Splinter Review
Bug 34558: Update custom.sql for it-IT webinstaller (4.20 KB, patch)
2023-10-05 20:54 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Zeno Tajoli 2023-08-17 08:44:51 UTC
With new developments about transaltion, the file ../installer/data/mysql/localization/it-IT/custom.sql needs an update.
Today, when you install a 23.05 version with Italian setup (it-IT),
you will see a warning about problems with Authorised values (AV).

We need to fix it and update the file.
Comment 1 Zeno Tajoli 2023-08-17 09:01:24 UTC
Created attachment 154507 [details]
Image of the bug
Comment 2 Zeno Tajoli 2023-08-17 12:11:51 UTC
Created attachment 154551 [details] [review]
patch for custom.sql
Comment 3 Zeno Tajoli 2023-08-17 12:13:12 UTC
It is an update of this file, here there are the specific customization for
italian users.

Test plan for the patch:
Start a web installation with italian language.
Select Marc21 as biblio format
Select all optional .sql files
See the warning present into the image.
Conclude the installation.
Apply the patch.
Drop and recreate the mysql db
Redone the installation with italian language.
Use the same options written above.
Now no more the warning.
Installation conclude OK
Comment 4 David Nind 2023-10-01 20:24:25 UTC
Hi Zeno.

I'm not seeing the error.

This what I see:

...

  Dati per la localiozzazione aggiunti

  * custom.sql

  L'installazione di base è completa.

  Nei prossimi passi sarete guidati a fare alcuni punti fondamentali, tra cui  l'utente di gestione con tutti i privilegi amministrativi (superlibrarian).
Puoi aiutare la comunità di Koha condividendo le tue statistiche con noi.

  Se vuoi condividere alcuni tuoi dati, attiva la funzionalità nella sezione "Condividi statistiche d'uso" del modulo di amministrazione.

...


Here are my testing notes (so far) using koha-testing-docker (KTD) (note that KTD uses MARIA DB in strict mode by default):

1. Install the it-IT language:
   1.1 cd misc/translator
   1.2 ./translate update it-IT
   1.3 ./translate install it-IT

2. Test the web installer:
   2.1 Access the database server[1]: mysql -uroot -ppassword -hkoha-db-1
   2.2 Drop the koha_kohadev database: drop database koha_kohadev;
   2.3 Create the database: create database koha_kohadev;
   2.4 Add privileges (for a real installation, this would be limited): grant all  
       on 2.5 koha_kohadev.* to koha_kohadev;
   2.6 Restart everything (there may be some errors listed): flush_memcached 
       and then restart_all
   2.7 Access the web installer: go to 127.0.0.1:8081
   2.8 Use the database user name and password: get from 
       /etc/koha/sites/kohadev/koha-conf.xml (default: koha_kohadev, password)
   2.9 Continue through the installation process

In addition, your commit message needs to be formatted using these guidelines: https://wiki.koha-community.org/wiki/Commit_messages
Comment 5 Zeno Tajoli 2023-10-02 20:58:54 UTC
Probably the problem is presnt only on a specific platform. I use Debian 11 with MariaDb (default setup)
I change the commit file
Comment 6 David Nind 2023-10-02 22:21:18 UTC
(In reply to Zeno Tajoli from comment #5)
> Probably the problem is presnt only on a specific platform. I use Debian 11
> with MariaDb (default setup)
> I change the commit file

KTD (koha-testing-docker) by default is currently using Debian 11 and MariaDB 10.5.22.
Comment 7 Zeno Tajoli 2023-10-04 20:22:53 UTC
Created attachment 156558 [details] [review]
patch for custom.sql
Comment 8 Zeno Tajoli 2023-10-04 20:25:28 UTC
I do a new test and now the warning is not present.
So in fact is not more a bug fix but only a refactor / update of defaults.
I reformat the patch and rewrite test
Comment 9 David Nind 2023-10-05 17:09:16 UTC
Created attachment 156574 [details] [review]
Bug 34558: Update custom.sql for it-IT webinstaller

It is an update of this file, here there are the specific customization for
italian users. There are simple changes on defaults values.

To test it:
1 - Start a web installation with italian language.
2 - Select Marc21 as biblio format
3 - Select all optional .sql files
4 - Conclude the installation.
5 - Go to MySQL command line and do:
    SELET value FROM systempreferences where variable = 'BorrowersTitles'
    You see: 'Sig|Sig.ra|Sig.na'
6 - Apply the patch.
7 - Drop and recreate the mysql db
8 - Redone the installation with italian language.
9 - Use the same options written above.
10 - Conclude the installation.
11 - Go to MySQL command line and do:
    SELET value FROM systempreferences where variable = 'BorrowersTitles'
    You see: 'Sig|Sig.ra|Dott.|Dott.ssa'
12 - Refactor is OK

Signed-off-by: David Nind <david@davidnind.com>
Comment 10 David Nind 2023-10-05 17:10:24 UTC
Comment on attachment 156558 [details] [review]
patch for custom.sql

Mark the original patch as obsolete.
Comment 11 David Nind 2023-10-05 17:15:40 UTC
Updated testing notes (using koha-testing-docker (KTD)):

1. Install the it-IT language:
   1.1 cd misc/translator
   1.2 ./translate update it-IT
   1.3 ./translate install it-IT

2. Initial run through the web installer:
   2.1 Access the database server[1]: mysql -uroot -ppassword -hkoha-db-1
   2.2 Drop the koha_kohadev database: drop database koha_kohadev;
   2.3 Create the database: create database koha_kohadev;
   2.4 Add privileges (for a real installation, this would be limited): grant all  
       on koha_kohadev.* to koha_kohadev;
   2.5 Restart everything (there may be some errors listed): flush_memcached 
       and then restart_all
   2.6 Access the web installer: go to 127.0.0.1:8081
   2.7 Use the database user name and password: get from 
       /etc/koha/sites/kohadev/koha-conf.xml (default: koha_kohadev, password)
   2.8 Continue through the installation process

3. As per the test plan (step 5), then apply the patch and repeat 2.

4. Note that the SQL statement for step 5 should be 'SELECT' not 'SELET' in English: SELECT value FROM systempreferences where variable = 'BorrowersTitles'
Comment 12 Katrin Fischer 2023-10-05 20:54:23 UTC
Created attachment 156587 [details] [review]
Bug 34558: Update custom.sql for it-IT webinstaller

It is an update of this file, here there are the specific customization for
italian users. There are simple changes on defaults values.

To test it:
1 - Start a web installation with italian language.
2 - Select Marc21 as biblio format
3 - Select all optional .sql files
4 - Conclude the installation.
5 - Go to MySQL command line and do:
    SELET value FROM systempreferences where variable = 'BorrowersTitles'
    You see: 'Sig|Sig.ra|Sig.na'
6 - Apply the patch.
7 - Drop and recreate the mysql db
8 - Redone the installation with italian language.
9 - Use the same options written above.
10 - Conclude the installation.
11 - Go to MySQL command line and do:
    SELECT value FROM systempreferences where variable = 'BorrowersTitles'
    You see: 'Sig|Sig.ra|Dott.|Dott.ssa'
12 - Refactor is OK

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 13 Tomás Cohen Arazi 2023-10-09 14:43:16 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 14 Fridolin Somers 2023-10-09 19:19:17 UTC
Pushed to 23.05.x for 23.05.05
Comment 15 Matt Blenkinsop 2023-10-17 17:36:05 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x