Bug 34569 - misc/cronjobs/holds/holds_reminder.pl problem with trigger arg
Summary: misc/cronjobs/holds/holds_reminder.pl problem with trigger arg
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Fridolin Somers
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-17 20:38 UTC by Fridolin Somers
Modified: 2023-12-28 20:47 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.04,22.11.10


Attachments
Bug 34569: Fix misc/cronjobs/holds/holds_reminder.pl trigger arg (1.54 KB, patch)
2023-08-17 20:43 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 34569: Fix misc/cronjobs/holds/holds_reminder.pl trigger arg (1.63 KB, patch)
2023-08-21 14:40 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 34569: Fix misc/cronjobs/holds/holds_reminder.pl trigger arg (1.67 KB, patch)
2023-08-25 10:48 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2023-08-17 20:38:13 UTC
misc/cronjobs/holds/holds_reminder.pl help says one can use arge -t for --triggered
But not implemented in code.
Should be like in misc/cronjobs/overdue_notices.pl :
  't|triggered'    => \$triggered,
Comment 1 Fridolin Somers 2023-08-17 20:43:56 UTC
Created attachment 154579 [details] [review]
Bug 34569: Fix misc/cronjobs/holds/holds_reminder.pl trigger arg

misc/cronjobs/holds/holds_reminder.pl help says one can use arge -t for --triggered
But not implemented in code.
Should be like in misc/cronjobs/overdue_notices.pl :
  't|triggered'    => \$triggered,

Test plan :
Play with misc/cronjobs/holds/holds_reminder.pl with arg -t and
--trigger
Comment 2 Matt Blenkinsop 2023-08-21 14:40:25 UTC
Created attachment 154681 [details] [review]
Bug 34569: Fix misc/cronjobs/holds/holds_reminder.pl trigger arg

misc/cronjobs/holds/holds_reminder.pl help says one can use arge -t for --triggered
But not implemented in code.
Should be like in misc/cronjobs/overdue_notices.pl :
  't|triggered'    => \$triggered,

Test plan :
Play with misc/cronjobs/holds/holds_reminder.pl with arg -t and
--trigger

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 3 Katrin Fischer 2023-08-25 10:48:49 UTC
Created attachment 154801 [details] [review]
Bug 34569: Fix misc/cronjobs/holds/holds_reminder.pl trigger arg

misc/cronjobs/holds/holds_reminder.pl help says one can use arge -t for --triggered
But not implemented in code.
Should be like in misc/cronjobs/overdue_notices.pl :
  't|triggered'    => \$triggered,

Test plan :
Play with misc/cronjobs/holds/holds_reminder.pl with arg -t and
--trigger

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-09-01 15:09:12 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-09-08 06:14:23 UTC
Pushed to 23.05.x for 23.05.04
Comment 6 Matt Blenkinsop 2023-09-15 09:33:38 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x