We can't use "onclick" attributes with CSP and we generally try to avoid them in Koha. This report targets the PopupMARCFieldDoc() function in the cataloguing editor.
Created attachment 154583 [details] [review] Bug 34570: Remove use of "onclick" for PopupMARCFieldDoc() This change removes the "onclick" attribute for the MARC doc link in the cataloguing editor. Test plan: 0. Apply patch 1. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode=# 2. Click on the question mark (?) next to any of the MARC fields 3. Press the "Repeat this tag" button 4. Click on the question mark (?) on the cloned MARC field 5. Note that both times it worked
Created attachment 154585 [details] [review] Bug 34570: Remove use of "onclick" for PopupMARCFieldDoc() This change removes the "onclick" attribute for the MARC doc link in the cataloguing editor. Test plan: 0. Apply patch 1. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode=# 2. Click on the question mark (?) next to any of the MARC fields 3. Press the "Repeat this tag" button 4. Click on the question mark (?) on the cloned MARC field 5. Note that both times it worked Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Filled assignee :)
Created attachment 154792 [details] [review] Bug 34570: Remove use of "onclick" for PopupMARCFieldDoc() This change removes the "onclick" attribute for the MARC doc link in the cataloguing editor. Test plan: 0. Apply patch 1. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode=# 2. Click on the question mark (?) next to any of the MARC fields 3. Press the "Repeat this tag" button 4. Click on the question mark (?) on the cloned MARC field 5. Note that both times it worked Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.04
Nice work everyone! Pushed to oldstable for 22.11.x