Bug 34584 - Remove Twitter share button from the OPAC
Summary: Remove Twitter share button from the OPAC
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-21 15:30 UTC by Owen Leonard
Modified: 2023-09-19 12:22 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34584: Remove Twitter share button from the OPAC (3.30 KB, patch)
2023-08-21 17:04 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34584: Remove Twitter share button from the OPAC (3.38 KB, patch)
2023-08-22 08:28 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 34584: Remove Twitter share button from the OPAC (3.42 KB, patch)
2023-08-24 20:16 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 34584: (QA follow-up) Update system preference SocialNetworks (2.78 KB, patch)
2023-08-24 20:16 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-08-21 15:30:07 UTC
Since Twitter doesn't exist anymore we should remove its share button from the OPAC.
Comment 1 Owen Leonard 2023-08-21 17:04:59 UTC
Created attachment 154684 [details] [review]
Bug 34584: Remove Twitter share button from the OPAC

This patch removes the option to share content in the OPAC via Twitter
now that Twitter doesn't exist anymore.

To test, apply the patch and go to Administration -> System preferences.

- Search for "SocialNetworks."
- The menu of options should contain only email, Facebook, and LinkedIn.
- Select all options and save.
- In the OPAC, locate a bibliographic record and view its details.
- In the right-hand sidebar, you should only see options to share via
  email, Facebook, and LinkedIn.
Comment 2 Matt Blenkinsop 2023-08-22 08:28:59 UTC
Created attachment 154685 [details] [review]
Bug 34584: Remove Twitter share button from the OPAC

This patch removes the option to share content in the OPAC via Twitter
now that Twitter doesn't exist anymore.

To test, apply the patch and go to Administration -> System preferences.

- Search for "SocialNetworks."
- The menu of options should contain only email, Facebook, and LinkedIn.
- Select all options and save.
- In the OPAC, locate a bibliographic record and view its details.
- In the right-hand sidebar, you should only see options to share via
  email, Facebook, and LinkedIn.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 3 Katrin Fischer 2023-08-24 20:16:38 UTC
Created attachment 154750 [details] [review]
Bug 34584: Remove Twitter share button from the OPAC

This patch removes the option to share content in the OPAC via Twitter
now that Twitter doesn't exist anymore.

To test, apply the patch and go to Administration -> System preferences.

- Search for "SocialNetworks."
- The menu of options should contain only email, Facebook, and LinkedIn.
- Select all options and save.
- In the OPAC, locate a bibliographic record and view its details.
- In the right-hand sidebar, you should only see options to share via
  email, Facebook, and LinkedIn.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Katrin Fischer 2023-08-24 20:16:42 UTC
Created attachment 154751 [details] [review]
Bug 34584: (QA follow-up) Update system preference SocialNetworks

SocialNetworks was set to be YesNo, but is actual choice with
3 options: linkedin, facebook, email.

This updates the database and the sysprefs.sql file.

It doesn't correct the value, but if it still contains twitter, this
will be fixed by the next change of the pref and has no negative
consequences.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2023-09-01 14:10:49 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-09-08 00:41:31 UTC
I propose not to backport on stable branches.
So we do not disturb users.