Since Twitter doesn't exist anymore we should remove its share button from the OPAC.
Created attachment 154684 [details] [review] Bug 34584: Remove Twitter share button from the OPAC This patch removes the option to share content in the OPAC via Twitter now that Twitter doesn't exist anymore. To test, apply the patch and go to Administration -> System preferences. - Search for "SocialNetworks." - The menu of options should contain only email, Facebook, and LinkedIn. - Select all options and save. - In the OPAC, locate a bibliographic record and view its details. - In the right-hand sidebar, you should only see options to share via email, Facebook, and LinkedIn.
Created attachment 154685 [details] [review] Bug 34584: Remove Twitter share button from the OPAC This patch removes the option to share content in the OPAC via Twitter now that Twitter doesn't exist anymore. To test, apply the patch and go to Administration -> System preferences. - Search for "SocialNetworks." - The menu of options should contain only email, Facebook, and LinkedIn. - Select all options and save. - In the OPAC, locate a bibliographic record and view its details. - In the right-hand sidebar, you should only see options to share via email, Facebook, and LinkedIn. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Created attachment 154750 [details] [review] Bug 34584: Remove Twitter share button from the OPAC This patch removes the option to share content in the OPAC via Twitter now that Twitter doesn't exist anymore. To test, apply the patch and go to Administration -> System preferences. - Search for "SocialNetworks." - The menu of options should contain only email, Facebook, and LinkedIn. - Select all options and save. - In the OPAC, locate a bibliographic record and view its details. - In the right-hand sidebar, you should only see options to share via email, Facebook, and LinkedIn. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 154751 [details] [review] Bug 34584: (QA follow-up) Update system preference SocialNetworks SocialNetworks was set to be YesNo, but is actual choice with 3 options: linkedin, facebook, email. This updates the database and the sysprefs.sql file. It doesn't correct the value, but if it still contains twitter, this will be fixed by the next change of the pref and has no negative consequences. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
I propose not to backport on stable branches. So we do not disturb users.
Updated the options in the manual.