To reproduce 1. Create an HTML customisation (in Staff interface -> tools -> HTML customisations) in the 'opaccredits' section. Give it some formatting i.e colours and headings 2. Save this and confirm it displays as expected on the OPAC 3. Create a custom page (in Staff interface -> tools -> pages) 4. Save this and open it in the OPAC 5. Notice the opaccredits section does not display as normal This is because the template for custom OPAC pages puts opaccredits inside the #main div, whereas other OPAC templates puts them outside the #main div
Created attachment 154876 [details] [review] Bug 34627: CMS pages do not correctly display the opaccredits footer This patch corrects the page structure of CMS pages in the OPAC so that the contents of the footer, including opaccredits, OpacKohaUrl, and the language selection bar, are displayed correctly. This patch contains indentation changes, so ignore whitespace when viewing the diff. To test you should have these settings: - OpacKohaUrl enabled in system preferences - Some content in the opaccredits HTML customization region - Some content in the OpacNav HTML customization region - At least one translation installed and enabled - The opaclanguagesdisplay preference enabled - The OpacLangSelectorMode set to "only footer" or "both top and footer" - Apply the patch and go to Tools -> Pages and create a page with the display location "OPAC." - Open the OPAC link for your newly-created page and confirm that the page looks correct: - The "main" region with the white background should contain the breadcrumb navigation, the sidebar OpacNav content, and the contents of your CMS page. - The opaccredits and OpacKohaUrl content should appear below that region. - The language selection footer should be at the bottom of the page.
Created attachment 154878 [details] [review] Bug 34627: CMS pages do not correctly display the opaccredits footer This patch corrects the page structure of CMS pages in the OPAC so that the contents of the footer, including opaccredits, OpacKohaUrl, and the language selection bar, are displayed correctly. This patch contains indentation changes, so ignore whitespace when viewing the diff. To test you should have these settings: - OpacKohaUrl enabled in system preferences - Some content in the opaccredits HTML customization region - Some content in the OpacNav HTML customization region - At least one translation installed and enabled - The opaclanguagesdisplay preference enabled - The OpacLangSelectorMode set to "only footer" or "both top and footer" - Apply the patch and go to Tools -> Pages and create a page with the display location "OPAC." - Open the OPAC link for your newly-created page and confirm that the page looks correct: - The "main" region with the white background should contain the breadcrumb navigation, the sidebar OpacNav content, and the contents of your CMS page. - The opaccredits and OpacKohaUrl content should appear below that region. - The language selection footer should be at the bottom of the page. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Created attachment 154892 [details] [review] Bug 34627: CMS pages do not correctly display the opaccredits footer This patch corrects the page structure of CMS pages in the OPAC so that the contents of the footer, including opaccredits, OpacKohaUrl, and the language selection bar, are displayed correctly. This patch contains indentation changes, so ignore whitespace when viewing the diff. To test you should have these settings: - OpacKohaUrl enabled in system preferences - Some content in the opaccredits HTML customization region - Some content in the OpacNav HTML customization region - At least one translation installed and enabled - The opaclanguagesdisplay preference enabled - The OpacLangSelectorMode set to "only footer" or "both top and footer" - Apply the patch and go to Tools -> Pages and create a page with the display location "OPAC." - Open the OPAC link for your newly-created page and confirm that the page looks correct: - The "main" region with the white background should contain the breadcrumb navigation, the sidebar OpacNav content, and the contents of your CMS page. - The opaccredits and OpacKohaUrl content should appear below that region. - The language selection footer should be at the bottom of the page. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Pushed to master for 23.11. Nice work everyone, thanks!
Thanks all! Can this please be backported for 23.05?
Pushed to 23.05.x for 23.05.04
Feature added by Bug 15326 in 22.11
Nice work everyone! Pushed to oldstable for 22.11.x