To recreate: 1. Place some holds and go to /reserve/request.pl for that bib. 2. If the reserves.expirationdate is set to today or some date in the past the date does not display in the Flatpickr instance. 3. Change the reserves.expirationdate to sometime in the future, the date displays. If staff cannot edit the reserves.expirationdate because it is in the past it still needs to display.
Created attachment 154891 [details] [review] Bug 34634: Show expirationdate of expired holds on reserve/request.pl To test: 1. Place some holds and go to /reserve/request.pl for that bib. 2. If the reserves.expirationdate is set to today or some date in the past the date does not display in the Flatpickr instance. 3. Change the reserves.expirationdate to sometime in the future, the date displays. 4. Aply patch, restart_all 5. Try steps 2-3 again. 6. This time if the expiration date is in the past you should see it displayed. However it will be uneditable. 7. Make sure holds with a expiration date in the future can still be properly edited.
Created attachment 154899 [details] [review] Bug 34634: Show expirationdate of expired holds on reserve/request.pl To test: 1. Place some holds and go to /reserve/request.pl for that bib. 2. If the reserves.expirationdate is set to today or some date in the past the date does not display in the Flatpickr instance. 3. Change the reserves.expirationdate to sometime in the future, the date displays. 4. Aply patch, restart_all 5. Try steps 2-3 again. 6. This time if the expiration date is in the past you should see it displayed. However it will be uneditable. 7. Make sure holds with a expiration date in the future can still be properly edited. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Created attachment 154905 [details] [review] Bug 34634: Show expirationdate of expired holds on reserve/request.pl To test: 1. Place some holds and go to /reserve/request.pl for that bib. 2. If the reserves.expirationdate is set to today or some date in the past the date does not display in the Flatpickr instance. 3. Change the reserves.expirationdate to sometime in the future, the date displays. 4. Aply patch, restart_all 5. Try steps 2-3 again. 6. This time if the expiration date is in the past you should see it displayed. However it will be uneditable. 7. Make sure holds with a expiration date in the future can still be properly edited. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Christine <chlee@pascolibraries.org>
Straightforward change, works nicely, QA tool happy. Passing QA
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.04
Nice work everyone! Pushed to oldstable for 22.11.x