Bug 34644 - Add clarifying text to sysprefs to indicate that MarcFieldsToOrder is a fallback to MarcItemFieldsToOrder
Summary: Add clarifying text to sysprefs to indicate that MarcFieldsToOrder is a fallb...
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on: 34645
Blocks:
  Show dependency treegraph
 
Reported: 2023-08-29 17:26 UTC by Nick Clemens (kidclamp)
Modified: 2024-01-04 20:56 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This updates the descriptions for system preferences MarcFieldsToOrder and MarcItemFieldsToOrder.
Version(s) released in:
24.05.00,23.11.02,23.05.08


Attachments
Bug 34644: Add clarifying text to sysprefs to indicate that MarcFieldsToOrder is a fallback to MarcItemFieldsToOrder (1.42 KB, patch)
2023-08-29 17:49 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 34644: Improve readability of sysprefs (2.43 KB, patch)
2023-08-29 17:53 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 34644: replacementprice is support by MarcFieldsToOrder but is not listed (1.32 KB, patch)
2023-08-29 18:20 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 34644: Add clarifying text to sysprefs to indicate that MarcFieldsToOrder is a fallback to MarcItemFieldsToOrder (1.46 KB, patch)
2023-08-30 00:18 UTC, David Nind
Details | Diff | Splinter Review
Bug 34644: Improve readability of sysprefs (2.48 KB, patch)
2023-08-30 00:18 UTC, David Nind
Details | Diff | Splinter Review
Bug 34644: replacementprice is support by MarcFieldsToOrder but is not listed (1.36 KB, patch)
2023-08-30 00:18 UTC, David Nind
Details | Diff | Splinter Review
Bug 34644: (follow-up) Additional edits to description (1.68 KB, patch)
2023-08-30 00:18 UTC, David Nind
Details | Diff | Splinter Review
Bug 34644: Add clarifying text to sysprefs to indicate that MarcFieldsToOrder is a fallback to MarcItemFieldsToOrder (1.53 KB, patch)
2023-12-19 15:25 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 34644: Improve readability of sysprefs (2.54 KB, patch)
2023-12-19 15:25 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 34644: replacementprice is support by MarcFieldsToOrder but is not listed (1.43 KB, patch)
2023-12-19 15:25 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 34644: (follow-up) Additional edits to description (1.74 KB, patch)
2023-12-19 15:25 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2023-08-29 17:26:08 UTC
In the code for addorderiso2709.pl we only use the fields form MFTO if MIFTO is not populated. This is not clear when setting things up
Comment 1 Kyle M Hall 2023-08-29 17:49:30 UTC
Created attachment 154913 [details] [review]
Bug 34644: Add clarifying text to sysprefs to indicate that MarcFieldsToOrder is a fallback to MarcItemFieldsToOrder

Clarify that fields will fall back to MarcFieldsToOrder from MarcItemFieldsToOrder.
Comment 2 Kyle M Hall 2023-08-29 17:53:30 UTC
Created attachment 154914 [details] [review]
Bug 34644: Improve readability of sysprefs
Comment 3 Kyle M Hall 2023-08-29 18:20:36 UTC
Created attachment 154916 [details] [review]
Bug 34644: replacementprice is support by MarcFieldsToOrder but is not listed
Comment 4 David Nind 2023-08-30 00:18:14 UTC
Created attachment 154929 [details] [review]
Bug 34644: Add clarifying text to sysprefs to indicate that MarcFieldsToOrder is a fallback to MarcItemFieldsToOrder

Clarify that fields will fall back to MarcFieldsToOrder from MarcItemFieldsToOrder.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2023-08-30 00:18:17 UTC
Created attachment 154930 [details] [review]
Bug 34644: Improve readability of sysprefs

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2023-08-30 00:18:20 UTC
Created attachment 154931 [details] [review]
Bug 34644: replacementprice is support by MarcFieldsToOrder but is not listed

Signed-off-by: David Nind <david@davidnind.com>
Comment 7 David Nind 2023-08-30 00:18:22 UTC
Created attachment 154932 [details] [review]
Bug 34644: (follow-up) Additional edits to description

Linked system preference in description to cross reference, and
and removed the spaces in the bracketed text.

Signed-off-by: David Nind <david@davidnind.com>
Comment 8 David Nind 2023-08-30 00:21:42 UTC
Testing notes:

1. Compared before and after text for the system preference.

2. I added a follow-up - linked system preference in the description for MarcItemFieldsToOrder (the same as we do for other preferences), and removed the spaces in the bracketed text.

A nice clarification!
Comment 9 Marcel de Rooy 2023-09-01 08:36:02 UTC
Moving to blocked since depends on a NSO.
Comment 10 Katrin Fischer 2023-09-17 13:33:08 UTC
Dependency is unlocked.
Comment 11 Katrin Fischer 2023-09-17 20:45:57 UTC
Blocked again :(
Comment 12 Martin Renvoize 2023-12-19 15:25:02 UTC
Created attachment 160019 [details] [review]
Bug 34644: Add clarifying text to sysprefs to indicate that MarcFieldsToOrder is a fallback to MarcItemFieldsToOrder

Clarify that fields will fall back to MarcFieldsToOrder from MarcItemFieldsToOrder.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 13 Martin Renvoize 2023-12-19 15:25:05 UTC
Created attachment 160020 [details] [review]
Bug 34644: Improve readability of sysprefs

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 14 Martin Renvoize 2023-12-19 15:25:07 UTC
Created attachment 160021 [details] [review]
Bug 34644: replacementprice is support by MarcFieldsToOrder but is not listed

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 15 Martin Renvoize 2023-12-19 15:25:10 UTC
Created attachment 160022 [details] [review]
Bug 34644: (follow-up) Additional edits to description

Linked system preference in description to cross reference, and
and removed the spaces in the bracketed text.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 16 Martin Renvoize 2023-12-19 15:25:41 UTC
That's a lot of patches for a minor string change in the end.

Still.. it is clearer now.

Passing QA
Comment 17 Katrin Fischer 2023-12-20 14:15:00 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 18 Fridolin Somers 2024-01-03 15:29:53 UTC
Pushed to 23.11.x for 23.11.02
Comment 19 Lucas Gass 2024-01-04 20:56:28 UTC
Backported to 23.05.x for upcoming 23.05.08