Bug 34708 - Ability to modify an order line to increase quantity of ordered item
Summary: Ability to modify an order line to increase quantity of ordered item
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 36620
  Show dependency treegraph
 
Reported: 2023-09-04 21:54 UTC by Aleisha Amohia
Modified: 2024-04-17 11:12 UTC (History)
5 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This allows to add additional items to an already saved order lines when items are created on order.
Version(s) released in:
23.11.00


Attachments
Bug 34708: [WIP] (2.21 KB, patch)
2023-09-11 20:38 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 34708: Add ability to modify orderline to increase quantity (6.60 KB, patch)
2023-09-12 23:59 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 34708: Add ability to modify orderline to increase quantity (6.66 KB, patch)
2023-09-22 08:55 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 34708: Add ability to modify orderline to increase quantity (7.20 KB, patch)
2023-11-04 23:40 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2023-09-04 21:54:15 UTC
Baskets that create an item when placing an order do NOT allow you to modify the order and increase the quantity. The only time a quantity can be increased is upon receiving.

We'd like to be able to modify orders in an open basket and increase the quantity.

This does not apply to baskets that create an item when receiving an order or cataloguing as you can modify these orders and increase the quantity.
Comment 1 Aleisha Amohia 2023-09-11 20:38:36 UTC
Created attachment 155520 [details] [review]
Bug 34708: [WIP]
Comment 2 Aleisha Amohia 2023-09-12 23:59:17 UTC
Created attachment 155580 [details] [review]
Bug 34708: Add ability to modify orderline to increase quantity

This enhancement allows libraries to modify an existing orderline and increase the quantity in the order. The quantity is increased by adding more items to the order, through the usual Item for which is visible when adding or modifying an order.

To test:

1. Ensure you have a budget, fund, vendor etc. to use the Acquisitions module
2. Open a new basket. Make sure you do NOT check the 'orders are standing' option
3. Add an order to the basket using any method. Add an item or more to this orderline and save the order to the basket
4. Click Modify to edit the orderline
5. Notice the quantity text field. Try to directly change this number. You'll get an error pop-up and be redirected back to the basket.

6. Apply the patch, restart services, refresh the basket page

7. Click Modify to edit the orderline
8. Notice the item form and Items list table is visible with your existing item(s) for this order. There should be no Action buttons as actions can't be done on an existing item order.
9. Confirm you are able to add more items to the Items list and to the order by filling out the form and clicking 'Add item' as normal. Confirm the quantity increases accordingly.
10. Confirm the Edit and Delete buttons for newly added items work as expected
11. Save and confirm the quantity for the orderline has increased
12. Confirm this behaviour persists with the other methods of adding new orders to a basket

Sponsored-by: Pymble Ladies' College
Comment 3 ByWater Sandboxes 2023-09-22 08:55:56 UTC
Created attachment 156039 [details] [review]
Bug 34708: Add ability to modify orderline to increase quantity

This enhancement allows libraries to modify an existing orderline and increase the quantity in the order. The quantity is increased by adding more items to the order, through the usual Item for which is visible when adding or modifying an order.

To test:

1. Ensure you have a budget, fund, vendor etc. to use the Acquisitions module
2. Open a new basket. Make sure you do NOT check the 'orders are standing' option
3. Add an order to the basket using any method. Add an item or more to this orderline and save the order to the basket
4. Click Modify to edit the orderline
5. Notice the quantity text field. Try to directly change this number. You'll get an error pop-up and be redirected back to the basket.

6. Apply the patch, restart services, refresh the basket page

7. Click Modify to edit the orderline
8. Notice the item form and Items list table is visible with your existing item(s) for this order. There should be no Action buttons as actions can't be done on an existing item order.
9. Confirm you are able to add more items to the Items list and to the order by filling out the form and clicking 'Add item' as normal. Confirm the quantity increases accordingly.
10. Confirm the Edit and Delete buttons for newly added items work as expected
11. Save and confirm the quantity for the orderline has increased
12. Confirm this behaviour persists with the other methods of adding new orders to a basket

Sponsored-by: Pymble Ladies' College
Signed-off-by: Katariina Hanhisalo <katariina.hanhisalo@xamk.fi>
Comment 4 Katrin Fischer 2023-11-04 23:40:10 UTC
Created attachment 158407 [details] [review]
Bug 34708: Add ability to modify orderline to increase quantity

This enhancement allows libraries to modify an existing orderline and increase the quantity in the order. The quantity is increased by adding more items to the order, through the usual Item for which is visible when adding or modifying an order.

To test:

1. Ensure you have a budget, fund, vendor etc. to use the Acquisitions module
2. Open a new basket. Make sure you do NOT check the 'orders are standing' option
3. Add an order to the basket using any method. Add an item or more to this orderline and save the order to the basket
4. Click Modify to edit the orderline
5. Notice the quantity text field. Try to directly change this number. You'll get an error pop-up and be redirected back to the basket.

6. Apply the patch, restart services, refresh the basket page

7. Click Modify to edit the orderline
8. Notice the item form and Items list table is visible with your existing item(s) for this order. There should be no Action buttons as actions can't be done on an existing item order.
9. Confirm you are able to add more items to the Items list and to the order by filling out the form and clicking 'Add item' as normal. Confirm the quantity increases accordingly.
10. Confirm the Edit and Delete buttons for newly added items work as expected
11. Save and confirm the quantity for the orderline has increased
12. Confirm this behaviour persists with the other methods of adding new orders to a basket

Sponsored-by: Pymble Ladies' College
Signed-off-by: Katariina Hanhisalo <katariina.hanhisalo@xamk.fi>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Perltidy
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2023-11-09 13:15:31 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-11-11 07:13:14 UTC
Enhancement not pushed to 23.05.x
Comment 7 Caroline Cyr La Rose 2024-01-11 21:11:45 UTC
The manual only says we can edit orders, without specifying with or without items. So I won't change anything there.