When adding a field, the sort options are 'Undef',0,1 Add a new field and leave sort at undef Save the mappings It breaks! Sort cannot be null The options should be 'Yes','No' in the dropdown as values 1,0
Created attachment 155337 [details] [review] Bug 34740: Update sort options in ES config to by Yes/No At some point the option for 'undef' was removed from te sort options and was collapsed to yes/no The dropdowns when adding a new field were missed, this patch corrects that. While undef in a mappings file wil stil load, when saving we should not privde undef any longer To test: 1 - Browse to bottom to add a new field on the 'Bibliographic records' tab in Administration > Search engine configuration (Elasticsearch) 2 - Set sortable column to undef, set other columns and provide a valid field 3 - Click '+Add' 4 - Click 'Save' 5 - At top of page you receive an error: An error occurred when updating mappings: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'sort' cannot be null at /kohadevbox/koha/Koha/SearchField.pm line 37 . 6 - Apply patch, restart all 7 - Add a new mapping, your only choices are Yes/No 8 - Save mapping 9 - Confirm it saves correctly
Created attachment 155519 [details] [review] Bug 34740: Update sort options in ES config to by Yes/No At some point the option for 'undef' was removed from te sort options and was collapsed to yes/no The dropdowns when adding a new field were missed, this patch corrects that. While undef in a mappings file wil stil load, when saving we should not privde undef any longer To test: 1 - Browse to bottom to add a new field on the 'Bibliographic records' tab in Administration > Search engine configuration (Elasticsearch) 2 - Set sortable column to undef, set other columns and provide a valid field 3 - Click '+Add' 4 - Click 'Save' 5 - At top of page you receive an error: An error occurred when updating mappings: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'sort' cannot be null at /kohadevbox/koha/Koha/SearchField.pm line 37 . 6 - Apply patch, restart all 7 - Add a new mapping, your only choices are Yes/No 8 - Save mapping 9 - Confirm it saves correctly Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com>
Created attachment 155764 [details] [review] Bug 34740: Update sort options in ES config to by Yes/No At some point the option for 'undef' was removed from te sort options and was collapsed to yes/no The dropdowns when adding a new field were missed, this patch corrects that. While undef in a mappings file wil stil load, when saving we should not privde undef any longer To test: 1 - Browse to bottom to add a new field on the 'Bibliographic records' tab in Administration > Search engine configuration (Elasticsearch) 2 - Set sortable column to undef, set other columns and provide a valid field 3 - Click '+Add' 4 - Click 'Save' 5 - At top of page you receive an error: An error occurred when updating mappings: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'sort' cannot be null at /kohadevbox/koha/Koha/SearchField.pm line 37 . 6 - Apply patch, restart all 7 - Add a new mapping, your only choices are Yes/No 8 - Save mapping 9 - Confirm it saves correctly Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Indeed Bug 30572 made sort column not null default 1
Pushed to 23.05.x for 23.05.04
Nice work everyone! Pushed to oldstable for 22.11.x