Bug 34743 - Incorrect POD in import_patrons.pl
Summary: Incorrect POD in import_patrons.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Matt Blenkinsop
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-08 11:03 UTC by Matt Blenkinsop
Modified: 2024-07-04 20:40 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.04,22.11.11
Circulation function:

Attachments
Bug 34743: Fix POD description (1.19 KB, patch)
2023-09-08 11:06 UTC, Matt Blenkinsop 		Details | Diff | Splinter Review
Bug 34743: Fix POD description (1.24 KB, patch)
2023-09-08 17:29 UTC, Laura Escamilla 		Details | Diff | Splinter Review
Bug 34743: Fix POD description (1.34 KB, patch)
2023-09-15 06:06 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Blenkinsop 2023-09-08 11:03:33 UTC 
There is a duplicated description in import_patrons.pl that causes confusion over what the flags are for
Comment 1 Matt Blenkinsop 2023-09-08 11:06:57 UTC 
Created attachment 155395 [details] [review]
Bug 34743: Fix POD description

Currently --expiration-from-today has the same definition as --update-expiration. The description has now been updated to reflect the fact that it will set the date from today, and not the patron's enrollment date

Test plan:
Look at the patch file and confirm that the POD now mentions today's date rather than the patron's enrollment date
Comment 2 Laura Escamilla 2023-09-08 17:29:48 UTC 
Created attachment 155453 [details] [review]
Bug 34743: Fix POD description

Currently --expiration-from-today has the same definition as --update-expiration. The description has now been updated to reflect the fact that it will set the date from today, and not the patron's enrollment date

Test plan:
Look at the patch file and confirm that the POD now mentions today's date rather than the patron's enrollment date

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Comment 3 Marcel de Rooy 2023-09-15 06:06:12 UTC 
Created attachment 155632 [details] [review]
Bug 34743: Fix POD description

Currently --expiration-from-today has the same definition as --update-expiration. The description has now been updated to reflect the fact that it will set the date from today, and not the patron's enrollment date

Test plan:
Look at the patch file and confirm that the POD now mentions today's date rather than the patron's enrollment date

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-09-15 14:59:05 UTC 
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-09-18 08:24:22 UTC 
Pushed to 23.05.x for 23.05.04
Comment 6 Matt Blenkinsop 2023-10-12 15:32:23 UTC 
Nice work everyone!

Pushed to oldstable for 22.11.x