Bug 34752 - Use AV descriptions in display for sort1/sort2 in basket display
Summary: Use AV descriptions in display for sort1/sort2 in basket display
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor (vote)
Assignee: Martin Renvoize
QA Contact: Testopia
URL:
Keywords: rel_23_11_candidate
Depends on: 34618
Blocks:
  Show dependency treegraph
 
Reported: 2023-09-11 10:15 UTC by Martin Renvoize
Modified: 2023-10-25 06:50 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34752: Add AV handling to sort1/sort2 on baskets (2.63 KB, patch)
2023-09-11 10:53 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 34752: Add AV handling to sort1/sort2 on baskets (2.68 KB, patch)
2023-09-12 04:52 UTC, David Nind
Details | Diff | Splinter Review
Bug 34752: (QA follow-up) perltidy (1.19 KB, patch)
2023-09-15 20:41 UTC, Emily Lamancusa
Details | Diff | Splinter Review
Bug 34752: Add AV handling to sort1/sort2 on baskets (3.40 KB, patch)
2023-10-12 20:17 UTC, Emily Lamancusa
Details | Diff | Splinter Review
Bug 34752: (QA follow-up) perltidy (1.25 KB, patch)
2023-10-12 20:17 UTC, Emily Lamancusa
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2023-09-11 10:15:04 UTC
Bug 34618 added the sort1 and sort2 fields to the display for baskets, however it's didn't account for when those fields are linked to an AV.
Comment 1 Martin Renvoize 2023-09-11 10:53:45 UTC
Created attachment 155474 [details] [review]
Bug 34752: Add AV handling to sort1/sort2 on baskets

This patch adds Authorized Value handling for the display of sort1 and
sort2 fields in the acquisitions basket display page.
Comment 2 Martin Renvoize 2023-09-11 10:55:34 UTC
Trivial follow-up to bug 34618.. I'm going straight to Signed off here as really it could have been done inline as a QA follow-up.

Just one final set of eyes to double check it's all working as expected (with and without AV's configured for a pair of funds used in the same basket would be a great test).
Comment 3 David Nind 2023-09-12 04:52:25 UTC
Created attachment 155526 [details] [review]
Bug 34752: Add AV handling to sort1/sort2 on baskets

This patch adds Authorized Value handling for the display of sort1 and
sort2 fields in the acquisitions basket display page.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2023-09-12 04:56:53 UTC
Changing back to needs sign off - not sure I tested it correctly.

Will leave for someone who understands this a bit more to sign off.
Comment 5 Katrin Fischer 2023-09-12 07:29:53 UTC
For a test plan:

* You need a budget and at least 2 funds.
* For the funds select different AV for the statistic fields, leave at least one without any AV (will be a free text entry)
* Create a basket 
* Add 2 order lines, using your different funds and different statistic settings
  Make sure you also type into the one without AV :)
* Verify the AV show the correct description/text on the basket summary page
Comment 6 David Nind 2023-09-12 16:51:55 UTC
(In reply to Katrin Fischer from comment #5)
> For a test plan:

Thanks Katrin! 

Looks like I did test it correctly, changing back to signed off.
Comment 7 Emily Lamancusa 2023-09-15 20:41:17 UTC
Created attachment 155718 [details] [review]
Bug 34752: (QA follow-up) perltidy
Comment 8 Emily Lamancusa 2023-09-15 20:42:28 UTC
Trivial patch, works and makes sense. Passing QA
Comment 9 Katrin Fischer 2023-09-15 21:17:34 UTC
Hi Elam, it looks like the first patch is missing your sign-off line, do you want to fix? And thx for QA!
Comment 10 Emily Lamancusa 2023-10-12 20:17:05 UTC
Created attachment 156993 [details] [review]
Bug 34752: Add AV handling to sort1/sort2 on baskets

This patch adds Authorized Value handling for the display of sort1 and
sort2 fields in the acquisitions basket display page.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: emlam <emily.lamancusa@montgomerycountymd.gov>
Comment 11 Emily Lamancusa 2023-10-12 20:17:07 UTC
Created attachment 156994 [details] [review]
Bug 34752: (QA follow-up) perltidy

Signed-off-by: emlam <emily.lamancusa@montgomerycountymd.gov>
Comment 12 Emily Lamancusa 2023-10-12 20:18:40 UTC
Added my sign-off lines (plus a trivial rebase)
Comment 13 Tomás Cohen Arazi 2023-10-18 13:23:05 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 14 Fridolin Somers 2023-10-25 06:50:30 UTC
Depends on Bug 34618 not in 23.05.x