Bug 34769 - Improve translation of title tags: Patron lists
Summary: Improve translation of title tags: Patron lists
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 33906
  Show dependency treegraph
 
Reported: 2023-09-12 16:22 UTC by Owen Leonard
Modified: 2023-11-10 02:08 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34769: Improve translation of title tags: Patron lists (4.37 KB, patch)
2023-09-12 16:32 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34769: Improve translation of title tags: Patron lists (4.41 KB, patch)
2023-10-22 00:13 UTC, David Nind
Details | Diff | Splinter Review
Bug 34769: Improve translation of title tags: Patron lists (4.47 KB, patch)
2023-11-01 21:24 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-09-12 16:22:43 UTC
This patch will modify patron lists templates in the staff client so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %]
Comment 1 Owen Leonard 2023-09-12 16:32:21 UTC
Created attachment 155563 [details] [review]
Bug 34769: Improve translation of title tags: Patron lists

This patch updates patron lists templates so that title tags can be more
easily translated. Some templates have been updated for consistency as
well: Harmonizing page title, breaddrumb navigation, and page headers.

To test, apply the patch and confirm that the following pages have the
correct title tags:

- Tools -> Patron lists
  - New patron list
  - View patron list
  - Edit patron list
Comment 2 David Nind 2023-10-22 00:13:29 UTC
Created attachment 157600 [details] [review]
Bug 34769: Improve translation of title tags: Patron lists

This patch updates patron lists templates so that title tags can be more
easily translated. Some templates have been updated for consistency as
well: Harmonizing page title, breaddrumb navigation, and page headers.

To test, apply the patch and confirm that the following pages have the
correct title tags:

- Tools -> Patron lists
  - New patron list
  - View patron list
  - Edit patron list

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2023-11-01 21:24:33 UTC
Created attachment 158218 [details] [review]
Bug 34769: Improve translation of title tags: Patron lists

This patch updates patron lists templates so that title tags can be more
easily translated. Some templates have been updated for consistency as
well: Harmonizing page title, breaddrumb navigation, and page headers.

To test, apply the patch and confirm that the following pages have the
correct title tags:

- Tools -> Patron lists
  - New patron list
  - View patron list
  - Edit patron list

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-11-03 15:06:02 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-11-10 02:08:19 UTC
Enhancement not pushed to 23.05.x