Bug 34773 - Improve translation of title tags: Cataloging tools
Summary: Improve translation of title tags: Cataloging tools
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 33906
  Show dependency treegraph
 
Reported: 2023-09-12 18:00 UTC by Owen Leonard
Modified: 2023-11-10 07:07 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34773: Improve translation of title tags: Cataloging tools (32.52 KB, patch)
2023-09-14 16:11 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34773: Improve translation of title tags: Cataloging tools (33.33 KB, patch)
2023-09-14 16:38 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34773: (follow-up) Missed inventory template (1.23 KB, patch)
2023-09-15 13:41 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34773: (follow-up) Missed templates (4.97 KB, patch)
2023-09-15 18:48 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34773: Improve translation of title tags: Cataloging tools (33.42 KB, patch)
2023-11-02 23:12 UTC, David Nind
Details | Diff | Splinter Review
Bug 34773: (follow-up) Missed templates (5.01 KB, patch)
2023-11-02 23:12 UTC, David Nind
Details | Diff | Splinter Review
Bug 34773: Improve translation of title tags: Cataloging tools (33.48 KB, patch)
2023-11-05 10:25 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 34773: (follow-up) Missed templates (5.07 KB, patch)
2023-11-05 10:25 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-09-12 18:00:55 UTC
This patch will modify cataloging tool templates in the staff client so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %]
Comment 1 Owen Leonard 2023-09-14 16:11:57 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2023-09-14 16:38:56 UTC
Created attachment 155622 [details] [review]
Bug 34773: Improve translation of title tags: Cataloging tools

This patch modifies cataloging tools templates so that title tags can be
more easily translated. The patch also makes some modifications to
titles, breadcrumb navigation, and page headers in order to make them
more consistent with each other and with other similar pages.

Note that stockrotation.pl has been modified so that rota information is
available to the template in more cases for the purpose of showing that
information in navigation and headings.

To test, apply the patch and go to Cataloging. Test each page and each
variation of the page to confirm that titles, breadcrumbs, and page
headers look correct.

- Export catalog data
- Stage records for import
  - Main page
  - Upload file -> Stage for import
- Manage staged records
  - Main page
    - Batch details
      - Import batch
- Batch item modification and batch item deletion
  - Main page
    - Submit batch
      - Save
- Batch record modification
  - Main page
    - Submit batch
      - Modify selected
- Batch record deletion
  - Main page
    - Submit batch
      - Delete selected
- MARC modification templates
  - Main page
    - Edit actions for a template
- Item modifications by age
  - Main page
    - Add rules
- Stock rotation
  - Main page
    - New rota
    - Edit rota
    - Manage stages for rota
      - New stage
      - Edit stage
    - Manage items for rota
      - Add items
Comment 3 Owen Leonard 2023-09-15 13:41:27 UTC
Created attachment 155668 [details] [review]
Bug 34773: (follow-up) Missed inventory template

Test Cataloging -> Inventory and the results page after submitting a
batch of barcodes.
Comment 4 Owen Leonard 2023-09-15 18:48:22 UTC
Created attachment 155710 [details] [review]
Bug 34773: (follow-up) Missed templates

This patch fixes three templates I missed the first time around:
Inventory, MARC diff view, and Upload local cover images.

- Cataloging -> Inventory and the results page after submitting a
  batch of barcodes.
- Cataloging -> Manage staged records -> Select a batch which includes
  record matches: Click the "View" link in the "Diff" column for a
  record which has a match.
- Cataloging -> Upload local cover image (with LocalCoverImages enabled)
Comment 5 David Nind 2023-11-02 23:12:00 UTC
Created attachment 158295 [details] [review]
Bug 34773: Improve translation of title tags: Cataloging tools

This patch modifies cataloging tools templates so that title tags can be
more easily translated. The patch also makes some modifications to
titles, breadcrumb navigation, and page headers in order to make them
more consistent with each other and with other similar pages.

Note that stockrotation.pl has been modified so that rota information is
available to the template in more cases for the purpose of showing that
information in navigation and headings.

To test, apply the patch and go to Cataloging. Test each page and each
variation of the page to confirm that titles, breadcrumbs, and page
headers look correct.

- Export catalog data
- Stage records for import
  - Main page
  - Upload file -> Stage for import
- Manage staged records
  - Main page
    - Batch details
      - Import batch
- Batch item modification and batch item deletion
  - Main page
    - Submit batch
      - Save
- Batch record modification
  - Main page
    - Submit batch
      - Modify selected
- Batch record deletion
  - Main page
    - Submit batch
      - Delete selected
- MARC modification templates
  - Main page
    - Edit actions for a template
- Item modifications by age
  - Main page
    - Add rules
- Stock rotation
  - Main page
    - New rota
    - Edit rota
    - Manage stages for rota
      - New stage
      - Edit stage
    - Manage items for rota
      - Add items

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2023-11-02 23:12:02 UTC
Created attachment 158296 [details] [review]
Bug 34773: (follow-up) Missed templates

This patch fixes three templates I missed the first time around:
Inventory, MARC diff view, and Upload local cover images.

- Cataloging -> Inventory and the results page after submitting a
  batch of barcodes.
- Cataloging -> Manage staged records -> Select a batch which includes
  record matches: Click the "View" link in the "Diff" column for a
  record which has a match.
- Cataloging -> Upload local cover image (with LocalCoverImages enabled)

Signed-off-by: David Nind <david@davidnind.com>
Comment 7 David Nind 2023-11-02 23:26:19 UTC
Testing notes and comments (using KTD):

1. I used one browser (in this case Chromium with clear history, cache, etc.) to walk through all the things listed, then after applying the patch walked through using another browser (in this Firefox Developer Edition with history, cache, etc., cleared).

2.  Noted for another bug? Batch item modification - Job has been enqueued page - there are two "Return to batch item modification" links. One is a link, the other is a white button with a tick

3. Stock rotation - maybe delete stage requires an update? 
   2.1 Enable StockRotation system preference
   2.2 When deleting a stage, the breadcrumb changes to Cataloging > Stock rotation, with a message "Are you sure you wnat to delete this stage?" (page title is Stock rotation > Cataloging > Koha).
   2.3 Should this be similar to editing? (Cataloging > Stick rotation > Manage stages for "Name of rota' > Modify <name> stage)

4. Other cataloging areas taken care of by other bugs:
   - Catalog concerns (CatalogConcerns system preference) - Bug 33916 
   - Label creator, Barcode image generator, Quick spine label creator - Bug 33916
   - Advanced editor, new record, and new from Z39.50/SRU (?) - Bug 33912
Comment 8 Katrin Fischer 2023-11-05 10:25:55 UTC
Created attachment 158440 [details] [review]
Bug 34773: Improve translation of title tags: Cataloging tools

This patch modifies cataloging tools templates so that title tags can be
more easily translated. The patch also makes some modifications to
titles, breadcrumb navigation, and page headers in order to make them
more consistent with each other and with other similar pages.

Note that stockrotation.pl has been modified so that rota information is
available to the template in more cases for the purpose of showing that
information in navigation and headings.

To test, apply the patch and go to Cataloging. Test each page and each
variation of the page to confirm that titles, breadcrumbs, and page
headers look correct.

- Export catalog data
- Stage records for import
  - Main page
  - Upload file -> Stage for import
- Manage staged records
  - Main page
    - Batch details
      - Import batch
- Batch item modification and batch item deletion
  - Main page
    - Submit batch
      - Save
- Batch record modification
  - Main page
    - Submit batch
      - Modify selected
- Batch record deletion
  - Main page
    - Submit batch
      - Delete selected
- MARC modification templates
  - Main page
    - Edit actions for a template
- Item modifications by age
  - Main page
    - Add rules
- Stock rotation
  - Main page
    - New rota
    - Edit rota
    - Manage stages for rota
      - New stage
      - Edit stage
    - Manage items for rota
      - Add items

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 9 Katrin Fischer 2023-11-05 10:25:58 UTC
Created attachment 158441 [details] [review]
Bug 34773: (follow-up) Missed templates

This patch fixes three templates I missed the first time around:
Inventory, MARC diff view, and Upload local cover images.

- Cataloging -> Inventory and the results page after submitting a
  batch of barcodes.
- Cataloging -> Manage staged records -> Select a batch which includes
  record matches: Click the "View" link in the "Diff" column for a
  record which has a match.
- Cataloging -> Upload local cover image (with LocalCoverImages enabled)

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 10 Tomás Cohen Arazi 2023-11-06 11:39:29 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 11 Fridolin Somers 2023-11-10 07:07:50 UTC
Enhancement not pushed to 23.05.x