Bug 34789 - Fix typo in erm_eholdings_titles
Summary: Fix typo in erm_eholdings_titles
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Matt Blenkinsop
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 34788
  Show dependency treegraph
 
Reported: 2023-09-14 12:12 UTC by Matt Blenkinsop
Modified: 2023-10-12 15:46 UTC (History)
9 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.04,22.11.11


Attachments
Bug 34789: Database and API update (5.06 KB, patch)
2023-09-14 12:29 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 34789: DBIC file (2.58 KB, patch)
2023-09-14 12:29 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 34789: Update usage throughout Koha modules and Vue components (8.12 KB, patch)
2023-09-14 12:29 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 34789: Update unit tests (3.25 KB, patch)
2023-09-14 12:29 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 34789: Database and API update (5.09 KB, patch)
2023-09-16 02:09 UTC, David Nind
Details | Diff | Splinter Review
Bug 34789: DBIC file (2.61 KB, patch)
2023-09-16 02:09 UTC, David Nind
Details | Diff | Splinter Review
Bug 34789: Update usage throughout Koha modules and Vue components (8.15 KB, patch)
2023-09-16 02:09 UTC, David Nind
Details | Diff | Splinter Review
Bug 34789: Update unit tests (3.28 KB, patch)
2023-09-16 02:09 UTC, David Nind
Details | Diff | Splinter Review
Bug 34789: Database and API update (5.15 KB, patch)
2023-09-17 13:21 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 34789: DBIC file (2.67 KB, patch)
2023-09-17 13:21 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 34789: Update usage throughout Koha modules and Vue components (8.21 KB, patch)
2023-09-17 13:21 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 34789: Update unit tests (3.33 KB, patch)
2023-09-17 13:21 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 34789: (QA follow-up) Improve output of database update (2.22 KB, patch)
2023-09-17 13:21 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 34789: (follow-up) Fix atomic update file (1.31 KB, patch)
2023-09-19 09:25 UTC, Matt Blenkinsop
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Blenkinsop 2023-09-14 12:12:03 UTC
preceeding_publication_title_id should be preceding_publication_title_id

This causes issues in importing KBART files for bug 34788
Comment 1 Matt Blenkinsop 2023-09-14 12:29:38 UTC
Created attachment 155607 [details] [review]
Bug 34789: Database and API update

Currently the erm_eholdings_titles table has a field called preceeding_publication_title_id. This should be preceding_publication_title_id
Comment 2 Matt Blenkinsop 2023-09-14 12:29:40 UTC
Created attachment 155608 [details] [review]
Bug 34789: DBIC file
Comment 3 Matt Blenkinsop 2023-09-14 12:29:43 UTC
Created attachment 155609 [details] [review]
Bug 34789: Update usage throughout Koha modules and Vue components
Comment 4 Matt Blenkinsop 2023-09-14 12:29:45 UTC
Created attachment 155610 [details] [review]
Bug 34789: Update unit tests
Comment 5 Matt Blenkinsop 2023-09-14 12:30:36 UTC
Test plan:
prove -v t/db_dependent/api/v1/erm_eholdings_titles.t
Run cypress test suite
Comment 6 David Nind 2023-09-16 02:09:01 UTC
Created attachment 155730 [details] [review]
Bug 34789: Database and API update

Currently the erm_eholdings_titles table has a field called preceeding_publication_title_id. This should be preceding_publication_title_id

Signed-off-by: David Nind <david@davidnind.com>
Comment 7 David Nind 2023-09-16 02:09:04 UTC
Created attachment 155731 [details] [review]
Bug 34789: DBIC file

Signed-off-by: David Nind <david@davidnind.com>
Comment 8 David Nind 2023-09-16 02:09:07 UTC
Created attachment 155732 [details] [review]
Bug 34789: Update usage throughout Koha modules and Vue components

Signed-off-by: David Nind <david@davidnind.com>
Comment 9 David Nind 2023-09-16 02:09:10 UTC
Created attachment 155733 [details] [review]
Bug 34789: Update unit tests

Signed-off-by: David Nind <david@davidnind.com>
Comment 10 David Nind 2023-09-16 02:12:49 UTC
Testing notes (using KTD):

1. After applying patches run: updatedatabase, dbic, yarn build

2. To run cypress tests: time perl /kohadevbox/misc4dev/run_tests.pl --run-cypress-tests-only (hope this is the correct way to do this - from https://wiki.koha-community.org/wiki/User:Victor_Grousset_-_tuxayo/Setup_Koha_environment_with_koha-testing-docker - see output - all cypress tests pass[1])


[1] Results from running Cypress tests:

     Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  KohaTable_spec.ts                        00:03        1        1        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  ERM/Agreements_spec.ts                   00:31        5        5        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  ERM/Dialog_spec.ts                       00:09        4        4        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  ERM/Licenses_spec.ts                     00:20        5        5        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  ERM/Packages_spec.ts                     00:20        5        5        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  ERM/Searchbar_spec.ts                    00:04        4        4        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  ERM/Titles_spec.ts                       00:37        6        6        -        -        - │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✔  All specs passed!                        02:07       30       30        -        -        -  

Done in 139.81s.
all good
Running [koha-shell kohadev -c "touch testing.success"]...

real	2m20.061s
user	0m31.341s
sys	0m18.387s
Comment 11 Katrin Fischer 2023-09-17 13:21:14 UTC
Created attachment 155750 [details] [review]
Bug 34789: Database and API update

Currently the erm_eholdings_titles table has a field called preceeding_publication_title_id. This should be preceding_publication_title_id

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 12 Katrin Fischer 2023-09-17 13:21:17 UTC
Created attachment 155751 [details] [review]
Bug 34789: DBIC file

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 13 Katrin Fischer 2023-09-17 13:21:20 UTC
Created attachment 155752 [details] [review]
Bug 34789: Update usage throughout Koha modules and Vue components

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 14 Katrin Fischer 2023-09-17 13:21:23 UTC
Created attachment 155753 [details] [review]
Bug 34789: Update unit tests

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 15 Katrin Fischer 2023-09-17 13:21:26 UTC
Created attachment 155754 [details] [review]
Bug 34789: (QA follow-up) Improve output of database update

* Adds description
* Adds column names to success messages

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 16 Katrin Fischer 2023-09-17 13:21:52 UTC
Hi Matt, 

small things: 

* the DBIC file should be marked with [DO NOT PUSH] to make it stand out a bit more. 
* the db update was missing the description, fixed in follow-up.
Comment 17 Matt Blenkinsop 2023-09-18 09:41:36 UTC
Noted, thanks Cait!
Comment 18 Tomás Cohen Arazi 2023-09-18 15:04:38 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 19 Fridolin Somers 2023-09-18 20:33:09 UTC
Pushed to 23.05.x for 23.05.04
Comment 20 Fridolin Somers 2023-09-18 20:34:51 UTC
Pushed to 23.05.x for 23.05.04
Comment 21 Andrii Nugged 2023-09-19 06:54:03 UTC
NOTE but it might be very urgent:


I am making our regular "piloting production build", we're following 23.05, and here is the issue we just bumped into:


    ALTER TABLE erm_eholdings_titles RENAME COLUMN preceding_publication_title_id TO preceding_publication_title_id;


This gives an atomic update error on older mariaDB because it appeared only:

RENAME COLUMN: MariaDB starting with 10.5.2


Older compatible syntax probably should be:

ALTER TABLE erm_eholdings_titles CHANGE COLUMN ...
Comment 22 Andrii Nugged 2023-09-19 06:59:34 UTC
( ALTER TABLE erm_eholdings_titles CHANGE COLUMN preceeding_publication_title_id preceding_publication_title_id varchar(255) DEFAULT NULL )
Comment 23 Jonathan Druart 2023-09-19 07:44:37 UTC
They are using preceeding_publication_title_id there: https://developer.ebsco.com/knowledge-services/holdingsiq/docs/downloading
Comment 24 Katrin Fischer 2023-09-19 07:52:16 UTC
(In reply to Jonathan Druart from comment #23)
> They are using preceeding_publication_title_id there:
> https://developer.ebsco.com/knowledge-services/holdingsiq/docs/downloading

Fun... I looked it up - preceding seems to be UK spelling?
Comment 25 Matt Blenkinsop 2023-09-19 08:17:55 UTC
The official NISO standard documentation for KBART uses "preceding" - see page 29 here: https://groups.niso.org/higherlogic/ws/public/download/16900/RP-9-2014_KBART.pdf

"preceeding" is an incorrect spelling, I think EBSCO need to change their docs!
https://www.merriam-webster.com/dictionary/preceeding

I'll add a follow-up to address Andrii's comments
Comment 26 Matt Blenkinsop 2023-09-19 08:31:48 UTC
I'll also test the EBSCO import - the titles will probably need amending before storing
Comment 27 Matt Blenkinsop 2023-09-19 09:25:05 UTC
Created attachment 155887 [details] [review]
Bug 34789: (follow-up) Fix atomic update file

Atomic update file had a versioning issue - now changed to be compatible with older versions

Please backport
Comment 28 Matt Blenkinsop 2023-09-19 09:26:09 UTC
Tomas - see follow-up patch that needs pushing to master
Comment 29 Tomás Cohen Arazi 2023-09-19 11:35:16 UTC
(In reply to Matt Blenkinsop from comment #28)
> Tomas - see follow-up patch that needs pushing to master

Pushed to master, thanks.
Comment 30 Fridolin Somers 2023-09-21 05:57:38 UTC
follow-up pushed to 23.05.x for 23.05.04
Comment 31 Matt Blenkinsop 2023-10-12 15:46:16 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x