Bug 34825 - Move Letters.t to t/db_dependent
Summary: Move Letters.t to t/db_dependent
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 34336
  Show dependency treegraph
 
Reported: 2023-09-19 06:49 UTC by Marcel de Rooy
Modified: 2023-10-17 17:11 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.05,22.11.11


Attachments
Bug 34825: Remove Test::DBIx::Class from Letters.t (4.12 KB, patch)
2023-09-19 07:13 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 34825: Merge Letters.t into t/db/Letters.t (5.33 KB, patch)
2023-09-19 07:13 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 34825: Remove Test::DBIx::Class from Letters.t (4.16 KB, patch)
2023-09-26 09:54 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 34825: Merge Letters.t into t/db/Letters.t (5.36 KB, patch)
2023-09-26 09:54 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2023-09-19 06:49:54 UTC

    
Comment 1 Marcel de Rooy 2023-09-19 07:13:46 UTC
Created attachment 155884 [details] [review]
Bug 34825: Remove Test::DBIx::Class from Letters.t

Includes a tidy.

Test plan:
Run t/Letters.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2023-09-19 07:13:49 UTC
Created attachment 155885 [details] [review]
Bug 34825: Merge Letters.t into t/db/Letters.t

Test plan:
Run t/db_dependent/Letters.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 3 Marcel de Rooy 2023-09-19 07:15:03 UTC
This is a trivial exercise. Run the test and qa tools..
Moving to SO
Comment 4 Jonathan Druart 2023-09-26 09:54:34 UTC
Created attachment 156205 [details] [review]
Bug 34825: Remove Test::DBIx::Class from Letters.t

Includes a tidy.

Test plan:
Run t/Letters.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Jonathan Druart 2023-09-26 09:54:36 UTC
Created attachment 156206 [details] [review]
Bug 34825: Merge Letters.t into t/db/Letters.t

Test plan:
Run t/db_dependent/Letters.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Tomás Cohen Arazi 2023-10-04 13:33:35 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 7 Fridolin Somers 2023-10-05 20:10:01 UTC
Pushed to 23.05.x for 23.05.05
Comment 8 Matt Blenkinsop 2023-10-17 17:11:59 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x