https://jenkins.koha-community.org/job/Koha_Master/lastCompletedBuild/consoleText It's full of: Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922.
I think those ones are new.
I think this was introduced by bug 34223 but I'm not sure why. Investigating.
Created attachment 156178 [details] [review] Bug 34838: Replace SUPER::AUTOLOAD with get_column I'm not 100% happy with this but I'm out of ideas. I think the problem warning happens because there is no method status or status_alias directly defined in Object.pm so it tries to define it, but it has already been defined by AUTOLOAD previously.
Created attachment 156200 [details] [review] Bug 34838: Replace SUPER::AUTOLOAD with get_column I'm not 100% happy with this but I'm out of ideas. I think the problem warning happens because there is no method status or status_alias directly defined in Object.pm so it tries to define it, but it has already been defined by AUTOLOAD previously. Test plan: prove t/db_dependent/Koha/Illbackend.t Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This fix seems correct to me.
Note that 4 warnings remain t/db_dependent/Koha/Illbackend.t .. Use of uninitialized value in exists at /kohadevbox/koha/Koha/Illrequest.pm line 1956. Use of uninitialized value in exists at /kohadevbox/koha/Koha/Illrequest.pm line 1961. Use of uninitialized value in exists at /kohadevbox/koha/Koha/Illrequest.pm line 1956. Use of uninitialized value in exists at /kohadevbox/koha/Koha/Illrequest.pm line 1961.
Created attachment 156201 [details] [review] Bug 34838: Only call strings_map if status_alias is not undef in status_alias cycle Because its highly likely that at least one request will have status_alias null in the database, the select MAX query will always return at least one result with NULL status_alias, throwing a warning, so we skip that
Created attachment 156202 [details] [review] Bug 34838: Only check for status in status graph if request has a status This check is required because when the existing_statuses method checks for the existing status_alias, it'll leave out the status from the query, so the status will be NULL for those particular query results when calling strings_map, throwing a warning
Created attachment 156204 [details] [review] Bug 34838: Tidy
Created attachment 156217 [details] [review] Bug 34838: Replace SUPER::AUTOLOAD with get_column I'm not 100% happy with this but I'm out of ideas. I think the problem warning happens because there is no method status or status_alias directly defined in Object.pm so it tries to define it, but it has already been defined by AUTOLOAD previously. Test plan: prove t/db_dependent/Koha/Illbackend.t Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 156218 [details] [review] Bug 34838: Only call strings_map if status_alias is not undef in status_alias cycle Because its highly likely that at least one request will have status_alias null in the database, the select MAX query will always return at least one result with NULL status_alias, throwing a warning, so we skip that Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 156219 [details] [review] Bug 34838: Only check for status in status graph if request has a status This check is required because when the existing_statuses method checks for the existing status_alias, it'll leave out the status from the query, so the status will be NULL for those particular query results when calling strings_map, throwing a warning Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 156220 [details] [review] Bug 34838: Tidy Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
*** Bug 34897 has been marked as a duplicate of this bug. ***
I am still getting a lot of warnings t/db_dependent/Illrequests.t .. 1/15 illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 101. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 111. t/db_dependent/Illrequests.t .. 6/15 Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 884. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 884. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 884. t/db_dependent/Illrequests.t .. 8/15 Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1013. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1013. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1013. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1033. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1033. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1033. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1071. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1071. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1071. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1114. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1114. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1114. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. t/db_dependent/Illrequests.t .. 11/15 Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. t/db_dependent/Illrequests.t .. 12/15 Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. t/db_dependent/Illrequests.t .. 14/15 Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922.
(In reply to Jonathan Druart from comment #6) > Note that 4 warnings remain > > t/db_dependent/Koha/Illbackend.t .. Use of uninitialized value in exists at > /kohadevbox/koha/Koha/Illrequest.pm line 1956. > Use of uninitialized value in exists at /kohadevbox/koha/Koha/Illrequest.pm > line 1961. > Use of uninitialized value in exists at /kohadevbox/koha/Koha/Illrequest.pm > line 1956. > Use of uninitialized value in exists at /kohadevbox/koha/Koha/Illrequest.pm > line 1961. So this was t/db_dependent/Koha/Illbackend.t But the problem remains for t/db_dependent/Illrequests.t
*** Bug 23040 has been marked as a duplicate of this bug. ***
Created attachment 166841 [details] [review] [23.11.x] Bug 34838: Replace SUPER::AUTOLOAD with get_column I'm not 100% happy with this but I'm out of ideas. I think the problem warning happens because there is no method status or status_alias directly defined in Object.pm so it tries to define it, but it has already been defined by AUTOLOAD previously. Test plan: prove t/db_dependent/Koha/Illbackend.t Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 166842 [details] [review] [23.11.x] Bug 34838: Only call strings_map if status_alias is not undef in status_alias cycle Because its highly likely that at least one request will have status_alias null in the database, the select MAX query will always return at least one result with NULL status_alias, throwing a warning, so we skip that Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 166843 [details] [review] [23.11.x] Bug 34838: Only check for status in status graph if request has a status This check is required because when the existing_statuses method checks for the existing status_alias, it'll leave out the status from the query, so the status will be NULL for those particular query results when calling strings_map, throwing a warning Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 166844 [details] [review] [23.11.x] Bug 34838: Tidy Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 166845 [details] [review] [23.11.x] Bug 34838: Use ->set to avoid method redefinition warnings This patch silences more warnings. To test 1. Be on 23.11.x 2. Apply the patches before this one 3. Run: $ ktd --shell k$ prove t/db_dependent/Illrequests.t => FAIL: Lots of warnings like this: Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 955. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 955. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1071. 4. Apply this patch 5. Repeat 3 => SUCCESS: No more warnings! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 166846 [details] [review] [23.11.x] Bug 34838: Replace SUPER::AUTOLOAD with get_column I'm not 100% happy with this but I'm out of ideas. I think the problem warning happens because there is no method status or status_alias directly defined in Object.pm so it tries to define it, but it has already been defined by AUTOLOAD previously. Test plan: prove t/db_dependent/Koha/Illbackend.t Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 166847 [details] [review] [23.11.x] Bug 34838: Only call strings_map if status_alias is not undef in status_alias cycle Because its highly likely that at least one request will have status_alias null in the database, the select MAX query will always return at least one result with NULL status_alias, throwing a warning, so we skip that Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 166848 [details] [review] [23.11.x] Bug 34838: Only check for status in status graph if request has a status This check is required because when the existing_statuses method checks for the existing status_alias, it'll leave out the status from the query, so the status will be NULL for those particular query results when calling strings_map, throwing a warning Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 166849 [details] [review] [23.11.x] Bug 34838: Tidy Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 166850 [details] [review] [23.11.x] Bug 34838: Use ->set to avoid method redefinition warnings This patch silences more warnings. To test 1. Be on 23.11.x 2. Apply the patches before this one 3. Run: $ ktd --shell k$ prove t/db_dependent/Illrequests.t => FAIL: Lots of warnings like this: Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 955. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 955. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1071. 4. Apply this patch 5. Repeat 3 => SUCCESS: No more warnings! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 166851 [details] [review] Bug 34838: Replace SUPER::AUTOLOAD with get_column I'm not 100% happy with this but I'm out of ideas. I think the problem warning happens because there is no method status or status_alias directly defined in Object.pm so it tries to define it, but it has already been defined by AUTOLOAD previously. Test plan: prove t/db_dependent/Koha/Illbackend.t Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 166852 [details] [review] Bug 34838: Only call strings_map if status_alias is not undef in status_alias cycle Because its highly likely that at least one request will have status_alias null in the database, the select MAX query will always return at least one result with NULL status_alias, throwing a warning, so we skip that Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 166853 [details] [review] Bug 34838: Only check for status in status graph if request has a status This check is required because when the existing_statuses method checks for the existing status_alias, it'll leave out the status from the query, so the status will be NULL for those particular query results when calling strings_map, throwing a warning Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 166854 [details] [review] Bug 34838: Tidy Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 166855 [details] [review] Bug 34838: Use ->set to avoid method redefinition warnings This patch silences more warnings. To test 1. Be on 23.11.x 2. Apply the patches before this one 3. Run: $ ktd --shell k$ prove t/db_dependent/Illrequests.t => FAIL: Lots of warnings like this: Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 955. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 955. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1071. 4. Apply this patch 5. Repeat 3 => SUCCESS: No more warnings! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(In reply to Jonathan Druart from comment #15) > I am still getting a lot of warnings Please check with my follow-up. There's a '23.11' and a 'main' version of the patch set. Besides the noise on the tests, this is a nightnmare on busy sites with some moderate ILL activity. as any action triggers many warnings per request that is displayed.
*** Bug 36918 has been marked as a duplicate of this bug. ***
As you have marked all the other bugs as duplicate of this one I am expecting all the warnings to be removed. But still: t/db_dependent/Illrequest/TypeDisclaimer.t ........... 1/5 Use of uninitialized value $type in string eq at /kohadevbox/koha/Koha/ILL/Request/Workflow/TypeDisclaimer.pm line 160. Use of uninitialized value $type in string eq at /kohadevbox/koha/Koha/ILL/Request/Workflow/TypeDisclaimer.pm line 160.