Bug 34873 - "Sending your cart/list" headings are inconsistent
Summary: "Sending your cart/list" headings are inconsistent
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-21 21:00 UTC by Katrin Fischer
Modified: 2023-12-12 21:37 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34873: Fix inconsistencies between "Sending your cart/list" headings (2.55 KB, patch)
2023-09-29 10:49 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34873: Fix inconsistencies between "Sending your cart/list" headings (2.60 KB, patch)
2023-10-01 20:44 UTC, David Nind
Details | Diff | Splinter Review
Screenshot - Send cart and lists pop-up windows (46.40 KB, image/png)
2023-10-01 20:47 UTC, David Nind
Details
Bug 34873: Fix inconsistencies between "Sending your cart/list" headings (2.66 KB, patch)
2023-10-07 14:29 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-09-21 21:00:22 UTC
The heading on the "Send list" pop-up in the staff interface is a h1 that appears quite big within the fieldset, while the "send cart" uses a legend, that appears in a nicer way.
Comment 1 Owen Leonard 2023-09-29 10:49:44 UTC
Created attachment 156377 [details] [review]
Bug 34873: Fix inconsistencies between "Sending your cart/list" headings

This patch modifies the templates for the popup windows which are shown
when you send a cart or a list via email in the staff interface.

To test, apply the patch and log into the staff interface.

- Perform a catalog search which will return results.
- Select one or more results and add them to the cart.
- Click the cart icon in the header menu to open the Cart popup.
- Click "Send". Compare this pop-up window to the version shown when
  sending a list:

- Open the Lists page and view the contents of a list.
- Click the "Send list" button in the toolbar.
- This popup should look correct and be consistent with the Cart
  version.
Comment 2 David Nind 2023-10-01 20:44:23 UTC
Created attachment 156449 [details] [review]
Bug 34873: Fix inconsistencies between "Sending your cart/list" headings

This patch modifies the templates for the popup windows which are shown
when you send a cart or a list via email in the staff interface.

To test, apply the patch and log into the staff interface.

- Perform a catalog search which will return results.
- Select one or more results and add them to the cart.
- Click the cart icon in the header menu to open the Cart popup.
- Click "Send". Compare this pop-up window to the version shown when
  sending a list:

- Open the Lists page and view the contents of a list.
- Click the "Send list" button in the toolbar.
- This popup should look correct and be consistent with the Cart
  version.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2023-10-01 20:47:50 UTC
Created attachment 156450 [details]
Screenshot - Send cart and lists pop-up windows

I've signed off as they now look much more consistent!

However, I did note that for the cart there is a more space before the heading than with the list (see attached image).

My CSS is not that great, but maybe this is something to do with the div for the container.
Comment 4 Katrin Fischer 2023-10-07 14:29:09 UTC
Created attachment 156678 [details] [review]
Bug 34873: Fix inconsistencies between "Sending your cart/list" headings

This patch modifies the templates for the popup windows which are shown
when you send a cart or a list via email in the staff interface.

To test, apply the patch and log into the staff interface.

- Perform a catalog search which will return results.
- Select one or more results and add them to the cart.
- Click the cart icon in the header menu to open the Cart popup.
- Click "Send". Compare this pop-up window to the version shown when
  sending a list:

- Open the Lists page and view the contents of a list.
- Click the "Send list" button in the toolbar.
- This popup should look correct and be consistent with the Cart
  version.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2023-10-09 14:44:05 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-10-09 19:13:50 UTC
Enhancement not pushed to 23.05.x
Comment 7 Caroline Cyr La Rose 2023-12-12 21:37:22 UTC
As far as I can see, this doesn't change anything for the manual. Feel free to reopen with more details if I'm wrong.