1) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Create a new FreeForm ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 3) Pick a request type and input "42" in cardnumber and select a random library. 4) Notice the "Place request with partners" icon is gone from the top action bar.
Created attachment 156180 [details] [review] Bug 34905: Fix icon Test plan, on k-t-d: 1) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Create a new FreeForm ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 3) Pick a request type and input "42" in cardnumber and select a random library. 4) Notice the "Place request with partners" icon is gone from the top action bar. 5) Apply patch. Repeat.
Created attachment 156181 [details] [review] Bug 34905: Fix icon Test plan, on k-t-d: 1) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Create a new FreeForm ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 3) Pick a request type and input "42" in cardnumber and select a random library. 4) Notice the "Place request with partners" icon is gone from the top action bar. 5) Apply patch. Repeat. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 156388 [details] [review] Bug 34905: Fix icon Test plan, on k-t-d: 1) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Create a new FreeForm ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 3) Pick a request type and input "42" in cardnumber and select a random library. 4) Notice the "Place request with partners" icon is gone from the top action bar. 5) Apply patch. Repeat. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Bug 32910 not pushed to 23.05.x