Item types are sorted by the code rather than the description in the Item type dropdown that is used when adding a new empty record as an order to a basket. To reproduce: 1. Go to Koha administration -> Item types. Add a new item type "B" with the description "Test" so it will be obvious if it is sorted by the code "B" instead of the description "Test". 2. Go to Acquisitions. Add to a basket from a new empty record 3. In the Catalog details section, note the Item type dropdown. Confirm your "Test" item type, is showing near the top of the list, indicating it has been sorted based on the code "B"
Created attachment 156248 [details] [review] Bug 34908: Sort item types alphabetically by description when adding a new empty record as an order to a basket To test: 1. Go to Koha administration -> Item types. Add a new item type "B" with the description "Test" so it will be obvious if it is sorted by the code "B" instead of the description "Test". 2. Go to Acquisitions. Add to a basket from a new empty record 3. In the Catalog details section, note the Item type dropdown. Confirm your "Test" item type, is showing near the top of the list, indicating it has been sorted based on the code "B" 4. Apply patch and restart services. Refresh the page. 5. Open the Item type dropdown again and confirm your "Test" item type is showing in the expected alphabetical order. Sponsored-by: South Taranaki District Council
Created attachment 156249 [details] [review] Bug 34908: Sort item types alphabetically by description when adding a new empty record as an order to a basket To test: 1. Go to Koha administration -> Item types. Add a new item type "B" with the description "Test" so it will be obvious if it is sorted by the code "B" instead of the description "Test". 2. Go to Acquisitions. Add to a basket from a new empty record 3. In the Catalog details section, note the Item type dropdown. Confirm your "Test" item type, is showing near the top of the list, indicating it has been sorted based on the code "B" 4. Apply patch and restart services. Refresh the page. 5. Open the Item type dropdown again and confirm your "Test" item type is showing in the expected alphabetical order. Sponsored-by: South Taranaki District Council Signed-off-by: David Nind <david@davidnind.com>
Created attachment 156982 [details] [review] Bug 34908: Sort item types alphabetically by description when adding a new empty record as an order to a basket To test: 1. Go to Koha administration -> Item types. Add a new item type "B" with the description "Test" so it will be obvious if it is sorted by the code "B" instead of the description "Test". 2. Go to Acquisitions. Add to a basket from a new empty record 3. In the Catalog details section, note the Item type dropdown. Confirm your "Test" item type, is showing near the top of the list, indicating it has been sorted based on the code "B" 4. Apply patch and restart services. Refresh the page. 5. Open the Item type dropdown again and confirm your "Test" item type is showing in the expected alphabetical order. NC amended patch - tidied Sponsored-by: South Taranaki District Council Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 23.11. Nice work everyone, thanks!
Small useful enhancement, I choose to backport. Pushed to 23.05.x for 23.05.05
Nice work everyone! Pushed to oldstable for 22.11.x