Account.t and Accounts.t use the datetime: 1970-01-01 00:00:01 This does not work in timezones UTC+1 to UTC+14 (note that they are also called GMT-1 to GMT-14 with sign reversed -- not confusing at all) Adding 14 hours to the above time makes the test pass too in those time zones which will only promote using unit tests :)
Created attachment 156221 [details] [review] Bug 34912: Add 14 hours to 1970 date in Account(s).t This makes those tests pass in whatever timezone. Test plan: Do not yet apply patch. Change timezone on commandline with: export TZ='Etc/GMT-14' NOTE: GMT-14 is what we also call UTC+14 (sign reversed). Run prove t/db_dependent/Accounts.t t/db_dependent/Koha/Account.t This fails now. Apply patch. Rerun tests and verify that they pass now. Bonus: Try some other time zone. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Trivial: Self SO
Created attachment 156380 [details] [review] Bug 34912: Add 14 hours to 1970 date in Account(s).t This makes those tests pass in whatever timezone. Test plan: Do not yet apply patch. Change timezone on commandline with: export TZ='Etc/GMT-14' NOTE: GMT-14 is what we also call UTC+14 (sign reversed). Run prove t/db_dependent/Accounts.t t/db_dependent/Koha/Account.t This fails now. Apply patch. Rerun tests and verify that they pass now. Bonus: Try some other time zone. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.05
Nice work everyone! Pushed to oldstable for 22.11.x