When you dont have the 50 sample patrons, the 51 returned by Mocks for userenv->{number} may not be found. And ArticleRequests.t fails. Can't call method "libraries_where_can_see_patrons" on an undefined value at /usr/share/koha/Koha/ArticleRequests.pm line 55.
Created attachment 156227 [details] [review] Bug 34916: Fix wrong borrowernumber in ArticleRequests.t Simple fix: Send patron to userenv instead of library only. Test plan: Do not apply patch. Remove borrowernumber 51. Run t/db_dependent/Koha/ArticleRequests.t. (FAIL) Apply patch, rerun test (PASS) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Trivial: self SO
This may affect more tests, but I stumbled over this prominent example.
Created attachment 156381 [details] [review] Bug 34916: Fix wrong borrowernumber in ArticleRequests.t Simple fix: Send patron to userenv instead of library only. Test plan: Do not apply patch. Remove borrowernumber 51. Run t/db_dependent/Koha/ArticleRequests.t. (FAIL) Apply patch, rerun test (PASS) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.05
Nice work everyone! Pushed to oldstable for 22.11.x