Bug 34931 - Collapsed additional attributes and identifiers with a PA_CLASS don't display well
Summary: Collapsed additional attributes and identifiers with a PA_CLASS don't display...
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Lucas Gass
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-27 12:42 UTC by Lucas Gass
Modified: 2023-11-14 14:50 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.06,22.11.12


Attachments
Bug 34931: Remove fieldset/legend in favor of div/h3 (3.05 KB, patch)
2023-10-12 22:15 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 34931: Remove fieldset/legend in favor of div/h3 (3.10 KB, patch)
2023-10-20 18:38 UTC, Brendan Lawlor
Details | Diff | Splinter Review
Bug 34931: Remove fieldset/legend in favor of div/h3 (3.15 KB, patch)
2023-11-05 00:44 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2023-09-27 12:42:52 UTC
To recreate: 

1. Create some PA_CLASS authorized values.
2. Create some custom patron attributes and add them to the newly created PA_CLASS's.
3.  Set CollapseFieldsPatronAddForm to collapse 'Additional attributes and identifiers'.
4. Go to a new or existing patron record. 
5. At the top of the page click the checkbox for "Show collapsed fields:".
6. Scroll down to that section and notice the PA_CLASS <legend> element is shown but not the individual patron attributes within that PA_CLASS.
Comment 1 Lucas Gass 2023-09-27 12:57:41 UTC
Furthermore, this produces invalid HTML. If you run the outputted HTML through a validator it will tell you:

fieldset not allowed as child of element ol
Comment 2 Lucas Gass 2023-10-12 22:15:29 UTC
Created attachment 157003 [details] [review]
Bug 34931: Remove fieldset/legend in favor of div/h3

1. Create some PA_CLASS authorized values.
2. Create some custom patron attributes and add them to the newly created PA_CLASS's.
3.  Set CollapseFieldsPatronAddForm to collapse 'Additional attributes and identifiers'.
4. Go to a new or existing patron record.
5. At the top of the page click the checkbox for "Show collapsed fields:".
6. Scroll down to that section and notice the PA_CLASS <legend> element is shown but not the individual patron attributes within that PA_CLASS.
7. Apply patch
8. Try again, the Additional attributes and identifiers fieldset should display properly.
Comment 3 Brendan Lawlor 2023-10-20 18:38:50 UTC
Created attachment 157562 [details] [review]
Bug 34931: Remove fieldset/legend in favor of div/h3

1. Create some PA_CLASS authorized values.
2. Create some custom patron attributes and add them to the newly created PA_CLASS's.
3.  Set CollapseFieldsPatronAddForm to collapse 'Additional attributes and identifiers'.
4. Go to a new or existing patron record.
5. At the top of the page click the checkbox for "Show collapsed fields:".
6. Scroll down to that section and notice the PA_CLASS <legend> element is shown but not the individual patron attributes within that PA_CLASS.
7. Apply patch
8. Try again, the Additional attributes and identifiers fieldset should display properly.

Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Comment 4 Katrin Fischer 2023-11-05 00:44:58 UTC
Created attachment 158422 [details] [review]
Bug 34931: Remove fieldset/legend in favor of div/h3

1. Create some PA_CLASS authorized values.
2. Create some custom patron attributes and add them to the newly created PA_CLASS's.
3.  Set CollapseFieldsPatronAddForm to collapse 'Additional attributes and identifiers'.
4. Go to a new or existing patron record.
5. At the top of the page click the checkbox for "Show collapsed fields:".
6. Scroll down to that section and notice the PA_CLASS <legend> element is shown but not the individual patron attributes within that PA_CLASS.
7. Apply patch
8. Try again, the Additional attributes and identifiers fieldset should display properly.

Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2023-11-08 13:00:05 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-11-10 08:02:37 UTC
Pushed to 23.05.x for 23.05.06
Comment 7 Pedro Amorim 2023-11-14 14:50:08 UTC
Nice work everyone!

Pushed to 22.11.x for next release