Bug 34946 - Remove the use of event attributes from self checkout and check-in
Summary: Remove the use of event attributes from self checkout and check-in
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 34709
  Show dependency treegraph
 
Reported: 2023-09-28 12:47 UTC by Owen Leonard
Modified: 2023-11-13 14:19 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.05,22.11.12


Attachments
Bug 34946: Remove the use of event attributes from self checkout and check-in (4.28 KB, patch)
2023-09-28 13:33 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34946: Remove the use of event attributes from self checkout and check-in (4.38 KB, patch)
2023-10-20 20:21 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review
Bug 34946: Remove the use of event attributes from self checkout and check-in (4.43 KB, patch)
2023-10-20 20:31 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-09-28 12:47:41 UTC
There are some event attributes in self checkout and self check-in templates. These should be removed in favor of defining events in JavaScript.
Comment 1 Owen Leonard 2023-09-28 13:33:20 UTC
Created attachment 156329 [details] [review]
Bug 34946: Remove the use of event attributes from self checkout and check-in

This patch removes the use of event attributes from the self checkout
and self check-in templates. These events are defined now along with the
other in-page JS.

To test you must have SelfCheckInModule and WebBasedSelfCheck
preferences enabled.

- Navigate to the self checkout interface
  (/cgi-bin/koha/sco/sco-main.pl).
- When the page loads, cursor focus should be automatically placed in
  the barcode field.
- Test the "munge history" feature from Bug 10016:
  [1] Start a web-based self-check session.
  [2] Enter a patron barcode.
  [3] Allow the self-check session to time out.
  [4] Use the back button.  You should get the patron barcode
      entry form; you should not be prompted to resubmit form input.
  [5] Enter a patron barcode, perform some transactions, then
      use the finish button.
  [6] Next, use the back button.  You should get the patron barcode
      entry form.
- Test the updated checkout_confirm function by submitting the "magic"
  barcode for checkout: __KOHA_NEW_CIRC__. The user's session should be
  ended.

- Navigate to the self check-in interface
  (/cgi-bin/koha/sco/sci-main.pl).
- Test the cursor focus and "munge history" feature on this page too.
Comment 2 Victor Grousset/tuxayo 2023-09-29 19:37:33 UTC
> To test you must have SelfCheckInModule and WebBasedSelfCheck
preferences enabled.

Is that all to do access the self check-in interface?

I get 404 on /cgi-bin/koha/sco/sci-main.pl on both opac and staff


>   [1] Start a web-based self-check session.

self-check-in right? I just discovered the existence of the self-check-in so I can easily confuse the two.
Comment 3 David Nind 2023-10-19 21:36:13 UTC
I didn't have any issue accessing - using KTD (in KTD need to enable SelfCheckInModule, WebBasedSelfCheck already enabled, only available on the OPAC side - http://127.0.0.1:8080/cgi-bin/koha/sco/sco-main.pl)
Comment 4 Victor Grousset/tuxayo 2023-10-20 19:03:52 UTC
(In reply to Victor Grousset/tuxayo from comment #2)
> I get 404 on /cgi-bin/koha/sco/sci-main.pl on both opac and staff

It's sci/sci-main.pl not sco/sci-main.pl T_T
Comment 5 Victor Grousset/tuxayo 2023-10-20 20:20:36 UTC
> To test you must have SelfCheckInModule and WebBasedSelfCheck
preferences enabled.

And also SelfCheckoutByLogin = cardnumber

Test plan updated.
Comment 6 Victor Grousset/tuxayo 2023-10-20 20:21:14 UTC
Created attachment 157574 [details] [review]
Bug 34946: Remove the use of event attributes from self checkout and check-in

This patch removes the use of event attributes from the self checkout
and self check-in templates. These events are defined now along with the
other in-page JS.

To test you must have SelfCheckInModule and WebBasedSelfCheck
preferences enabled. And SelfCheckoutByLogin = cardnumber.

- Navigate to the self checkout interface
  (/cgi-bin/koha/sco/sco-main.pl).
- When the page loads, cursor focus should be automatically placed in
  the barcode field.
- Test the "munge history" feature from Bug 10016:
  [1] Start a web-based self-check session.
  [2] Enter a patron barcode.
  [3] Allow the self-check session to time out.
  [4] Use the back button.  You should get the patron barcode
      entry form; you should not be prompted to resubmit form input.
  [5] Enter a patron barcode, perform some transactions, then
      use the finish button.
  [6] Next, use the back button.  You should get the patron barcode
      entry form.
- Test the updated checkout_confirm function by submitting the "magic"
  barcode for checkout: __KOHA_NEW_CIRC__. The user's session should be
  ended.

- Navigate to the self check-in interface
  (/cgi-bin/koha/sco/sci-main.pl).
- Test the cursor focus and "munge history" feature on this page too.

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 7 Victor Grousset/tuxayo 2023-10-20 20:22:46 UTC
It works!
Comment 8 Katrin Fischer 2023-10-20 20:31:16 UTC
Created attachment 157576 [details] [review]
Bug 34946: Remove the use of event attributes from self checkout and check-in

This patch removes the use of event attributes from the self checkout
and self check-in templates. These events are defined now along with the
other in-page JS.

To test you must have SelfCheckInModule and WebBasedSelfCheck
preferences enabled. And SelfCheckoutByLogin = cardnumber.

- Navigate to the self checkout interface
  (/cgi-bin/koha/sco/sco-main.pl).
- When the page loads, cursor focus should be automatically placed in
  the barcode field.
- Test the "munge history" feature from Bug 10016:
  [1] Start a web-based self-check session.
  [2] Enter a patron barcode.
  [3] Allow the self-check session to time out.
  [4] Use the back button.  You should get the patron barcode
      entry form; you should not be prompted to resubmit form input.
  [5] Enter a patron barcode, perform some transactions, then
      use the finish button.
  [6] Next, use the back button.  You should get the patron barcode
      entry form.
- Test the updated checkout_confirm function by submitting the "magic"
  barcode for checkout: __KOHA_NEW_CIRC__. The user's session should be
  ended.

- Navigate to the self check-in interface
  (/cgi-bin/koha/sco/sci-main.pl).
- Test the cursor focus and "munge history" feature on this page too.

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 9 Tomás Cohen Arazi 2023-10-20 20:36:58 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 10 Fridolin Somers 2023-10-26 06:28:06 UTC
Pushed to 23.05.x for 23.05.05
Comment 11 Matt Blenkinsop 2023-11-13 14:19:57 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x