Bug 34961 - RSS feed link in OPAC is missing sort parameter
Summary: RSS feed link in OPAC is missing sort parameter
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-29 15:09 UTC by Jason Robb
Modified: 2023-10-17 17:24 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes two RSS links in the OPAC search results template so that they include the correct parameters, including the descending sort by acquisition date.
Version(s) released in:
23.11.00,23.05.05,22.11.11


Attachments
Bug 34961: Add sort parameter to OPAC search results RSS feed link (3.01 KB, patch)
2023-10-02 15:03 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34961: Add sort parameter to OPAC search results RSS feed link (3.06 KB, patch)
2023-10-02 23:49 UTC, David Nind
Details | Diff | Splinter Review
Bug 34961: Add sort parameter to OPAC search results RSS feed link (3.12 KB, patch)
2023-10-03 10:20 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Robb 2023-09-29 15:09:41 UTC
In the past running a search in the OPAC with sorting included the sort in the RSS link so patrons could use feeds to track when new items are added.

The RSS link no longer appears to retain the sort.

For example, this search:

/cgi-bin/koha/opac-search.pl?idx=kw&q=street&sort_by=acqdate_dsc

Results in this RSS link:

/cgi-bin/koha/opac-search.pl?idx=kw&q=street&format=rss
Comment 1 Owen Leonard 2023-10-02 15:03:34 UTC
Created attachment 156455 [details] [review]
Bug 34961: Add sort parameter to OPAC search results RSS feed link

This patch corrects two RSS links in the OPAC search results template so
that they include the correct parameters, including the descending sort
by acquisition date.

To test, apply the patch and go to the OPAC.

- Perform a catalog search which will return search results.
- Next to the page heading "Your search returned X results" is an RSS
  link. Check the link to confirm that it has all the expected
  parameters:

  opac-search.pl?idx=kw&q=nude&count=50&sort_by=acqdate_dsc&format=rss

- Perform a search which will return no results and check the RSS link
  on that page. It should be the same.
Comment 2 David Nind 2023-10-02 23:49:23 UTC
Created attachment 156466 [details] [review]
Bug 34961: Add sort parameter to OPAC search results RSS feed link

This patch corrects two RSS links in the OPAC search results template so
that they include the correct parameters, including the descending sort
by acquisition date.

To test, apply the patch and go to the OPAC.

- Perform a catalog search which will return search results.
- Next to the page heading "Your search returned X results" is an RSS
  link. Check the link to confirm that it has all the expected
  parameters:

  opac-search.pl?idx=kw&q=nude&count=50&sort_by=acqdate_dsc&format=rss

- Perform a search which will return no results and check the RSS link
  on that page. It should be the same.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2023-10-03 10:20:44 UTC
Created attachment 156493 [details] [review]
Bug 34961: Add sort parameter to OPAC search results RSS feed link

This patch corrects two RSS links in the OPAC search results template so
that they include the correct parameters, including the descending sort
by acquisition date.

To test, apply the patch and go to the OPAC.

- Perform a catalog search which will return search results.
- Next to the page heading "Your search returned X results" is an RSS
  link. Check the link to confirm that it has all the expected
  parameters:

  opac-search.pl?idx=kw&q=nude&count=50&sort_by=acqdate_dsc&format=rss

- Perform a search which will return no results and check the RSS link
  on that page. It should be the same.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-10-04 15:09:45 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-10-06 00:34:25 UTC
Pushed to 23.05.x for 23.05.05
Comment 6 Matt Blenkinsop 2023-10-17 17:24:51 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x