In our terminology guide, & should only be used when it is part of a proper noun or a common abbreviation: https://wiki.koha-community.org/wiki/Terminology The add item form in the staff interface incorrectly use "Add & duplicate" (New > New item). To replicate: 1. In the staff interface, search for and select a record. 2. Select New > New item. 3. Note that "Add & duplicate" is one of the action buttons at the bottom of the add item form.
Created attachment 156435 [details] [review] Bug 34966: Terminology - fix add item form (& to and) This patch updates the add item form in the staff interface to change the 'Add & duplicate' button to 'Add and duplicate'. In our terminology guide, & should only be used when it is part of a proper noun or a common abbreviation: https://wiki.koha-community.org/wiki/Terminology Test plan: 1. In the staff interface, search for and select a record. 2. Select New > New item. 3. Note that "Add & duplicate" is one of the action buttons at the bottom of the add item form. 4. Apply the patch. 5. Refresh the page. 6. Note that the action button is now labelled 'Add and duplicate'. 7. Sign off! 8-) Signed-off-by: David Nind <david@davidnind.com>
Created attachment 157063 [details] [review] Bug 34966: Terminology - fix add item form (& to and) This patch updates the add item form in the staff interface to change the 'Add & duplicate' button to 'Add and duplicate'. In our terminology guide, & should only be used when it is part of a proper noun or a common abbreviation: https://wiki.koha-community.org/wiki/Terminology Test plan: 1. In the staff interface, search for and select a record. 2. Select New > New item. 3. Note that "Add & duplicate" is one of the action buttons at the bottom of the add item form. 4. Apply the patch. 5. Refresh the page. 6. Note that the action button is now labelled 'Add and duplicate'. 7. Sign off! 8-) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katariina Hanhisalo <katariina.hanhisalo@xamk.fi>
Created attachment 157066 [details] [review] Bug 34966: Terminology - fix add item form (& to and) This patch updates the add item form in the staff interface to change the 'Add & duplicate' button to 'Add and duplicate'. In our terminology guide, & should only be used when it is part of a proper noun or a common abbreviation: https://wiki.koha-community.org/wiki/Terminology Test plan: 1. In the staff interface, search for and select a record. 2. Select New > New item. 3. Note that "Add & duplicate" is one of the action buttons at the bottom of the add item form. 4. Apply the patch. 5. Refresh the page. 6. Note that the action button is now labelled 'Add and duplicate'. 7. Sign off! 8-) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katariina Hanhisalo <katariina.hanhisalo@xamk.fi> Signed-off-by: Reetta Pihlaja <reetta.pihlaja@siilinjarvi.fi>
Thanks Katariina and Reetta for signing off!
Created attachment 157152 [details] [review] Bug 34966: Terminology - fix add item form (& to and) This patch updates the add item form in the staff interface to change the 'Add & duplicate' button to 'Add and duplicate'. In our terminology guide, & should only be used when it is part of a proper noun or a common abbreviation: https://wiki.koha-community.org/wiki/Terminology Test plan: 1. In the staff interface, search for and select a record. 2. Select New > New item. 3. Note that "Add & duplicate" is one of the action buttons at the bottom of the add item form. 4. Apply the patch. 5. Refresh the page. 6. Note that the action button is now labelled 'Add and duplicate'. 7. Sign off! 8-) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katariina Hanhisalo <katariina.hanhisalo@xamk.fi> Signed-off-by: Reetta Pihlaja <reetta.pihlaja@siilinjarvi.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(In reply to David Nind from comment #4) > Thanks Katariina and Reetta for signing off! Thanks from me too :) Keep going!
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.06
Nice work everyone! Pushed to oldstable for 22.11.x