Bug 34967 - Move Prices.t to t/db_dependent
Summary: Move Prices.t to t/db_dependent
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Marcel de Rooy
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 34336
  Show dependency tree / graph
 
Reported: 2023-09-30 06:31 UTC by Marcel de Rooy
Modified: 2024-07-04 20:40 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.05,22.11.11
Circulation function:

Attachments
Bug 34967: Remove Test::DBIx::Class (34.32 KB, patch)
2023-09-30 06:33 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 34967: Add sample biblios and tidy some lines (4.33 KB, patch)
2023-09-30 06:33 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 34967: Move to db_dependent (638 bytes, patch)
2023-09-30 06:33 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 34967: Remove Test::DBIx::Class (34.34 KB, patch)
2023-10-03 10:04 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Bug 34967: Add sample biblios and tidy some lines (4.34 KB, patch)
2023-10-03 10:05 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Bug 34967: Move to db_dependent (655 bytes, patch)
2023-10-03 10:05 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2023-09-30 06:31:00 UTC 
Removing Test::DBIx::Class on the way.
Comment 1 Marcel de Rooy 2023-09-30 06:33:08 UTC 
Created attachment 156432 [details] [review]
Bug 34967: Remove Test::DBIx::Class

Move everything in one subtest

Test plan:
Run t/Prices.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2023-09-30 06:33:11 UTC 
Created attachment 156433 [details] [review]
Bug 34967: Add sample biblios and tidy some lines

Test plan:
Run t/Prices.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 3 Marcel de Rooy 2023-09-30 06:33:13 UTC 
Created attachment 156434 [details] [review]
Bug 34967: Move to db_dependent

No further changes.

Test plan:
Run t/db_dependent/Prices.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Marcel de Rooy 2023-09-30 06:33:39 UTC 
Trivial exercise: run the test! Self signoff
Comment 5 Katrin Fischer 2023-10-03 10:04:57 UTC 
Created attachment 156487 [details] [review]
Bug 34967: Remove Test::DBIx::Class

Move everything in one subtest

Test plan:
Run t/Prices.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Katrin Fischer 2023-10-03 10:05:00 UTC 
Created attachment 156488 [details] [review]
Bug 34967: Add sample biblios and tidy some lines

Test plan:
Run t/Prices.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Katrin Fischer 2023-10-03 10:05:03 UTC 
Created attachment 156489 [details] [review]
Bug 34967: Move to db_dependent

No further changes.

Test plan:
Run t/db_dependent/Prices.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Tomás Cohen Arazi (tcohen) 2023-10-03 13:24:02 UTC 
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 9 Fridolin Somers 2023-10-05 19:35:15 UTC 
Pushed to 23.05.x for 23.05.05
Comment 10 Matt Blenkinsop 2023-10-17 16:57:09 UTC 
Nice work everyone!

Pushed to oldstable for 22.11.x