There are no fixtures here. Can just be removed from the test.
Created attachment 156436 [details] [review] Bug 34968: Remove unneeded module from Search.t Test::DBIx::Class is not even used here. Just like C4::Biblio. We should remove TestBuilder too (this is t not t/db)! Test plan: Run t/Search.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Trivial (module cleanup): Self signoff
Why remove these tests? -use_ok('C4::Search'); -can_ok('C4::Search', - qw/_build_initial_query/);
(In reply to Katrin Fischer from comment #3) > Why remove these tests? > > -use_ok('C4::Search'); > -can_ok('C4::Search', > - qw/_build_initial_query/); Calling use_ok does not really add anything to our tests (here and in general too). We have a specific test that tests loading all modules in C4 and Koha in t/00-load.t. It will signal such a module. If the module would not load (and it would still be signed off..), the specific test will fail too anyway. For me the BEGIN blocks with use_ok are just unneeded ballast. We have no coding guideline to keep them and not one to remove them. It should not be a blocker for this report imo.
Created attachment 156503 [details] [review] Bug 34968: Remove unneeded module from Search.t Test::DBIx::Class is not even used here. Just like C4::Biblio. We should remove TestBuilder too (this is t not t/db)! Test plan: Run t/Search.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.05
Nice work everyone! Pushed to oldstable for 22.11.x