Bug 34970 - t/SuggestionEngine_AuthorityFile.t does not do anything with Test::DBIx::Class
Summary: t/SuggestionEngine_AuthorityFile.t does not do anything with Test::DBIx::Class
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Marcel de Rooy
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 34336
  Show dependency treegraph
 
Reported: 2023-09-30 06:49 UTC by Marcel de Rooy
Modified: 2023-10-17 17:12 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.05,22.11.11


Attachments
Bug 34970: Remove most modules from SuggestionEngine_AuthorityFile.t (1.86 KB, patch)
2023-09-30 07:01 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 34970: Remove most modules from SuggestionEngine_AuthorityFile.t (1.87 KB, patch)
2023-10-03 10:07 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2023-09-30 06:49:35 UTC
Remove Test::DBIx::Class here
Comment 1 Marcel de Rooy 2023-09-30 07:01:00 UTC
Created attachment 156438 [details] [review]
Bug 34970: Remove most modules from SuggestionEngine_AuthorityFile.t

There is really no need for all those modules here.
What remains, is just a trivial test.

Test plan:
Run t/SuggestionEngine_AuthorityFile.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2023-09-30 07:01:19 UTC
Trivial: self signoff
Comment 3 Katrin Fischer 2023-10-03 10:07:34 UTC
Created attachment 156490 [details] [review]
Bug 34970: Remove most modules from SuggestionEngine_AuthorityFile.t

There is really no need for all those modules here.
What remains, is just a trivial test.

Test plan:
Run t/SuggestionEngine_AuthorityFile.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-10-04 13:15:20 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-10-05 19:56:53 UTC
Pushed to 23.05.x for 23.05.05
Comment 6 Matt Blenkinsop 2023-10-17 17:12:23 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x