Bug 34977 - Allow to delete multiple patron lists at once
Summary: Allow to delete multiple patron lists at once
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Salah Ghedda
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-03 15:08 UTC by Salah Ghedda
Modified: 2024-02-19 18:41 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact: Caroline Cyr La Rose
Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/781
Text to go in the release notes:
This enhancement enables selecting and deleting multiple patron lists at once, instead of having to delete patron lists one at a time.
Version(s) released in:
23.11.00


Attachments
Bug 34977: The "Patron Lists" only allows deleting one list at a time (5.52 KB, patch)
2023-10-04 19:17 UTC, Salah Ghedda
Details | Diff | Splinter Review
Bug 34977: The "Patron Lists" only allows deleting one list at a time (5.52 KB, patch)
2023-10-04 19:44 UTC, Salah Ghedda
Details | Diff | Splinter Review
Bug 34977: The "Patron Lists" only allows deleting one list at a time (5.57 KB, patch)
2023-10-04 22:13 UTC, David Nind
Details | Diff | Splinter Review
Bug 34977: The "Patron Lists" only allows deleting one list at a time (5.63 KB, patch)
2023-11-03 16:16 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 34977: (QA follow-up) Tidy code (1.43 KB, patch)
2023-11-03 16:16 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 34977: The "Patron Lists" only allows deleting one list at a time (1.63 KB, patch)
2023-12-01 20:17 UTC, Salah Ghedda
Details | Diff | Splinter Review
Bug 34977: (QA follow-up) Tidy code (1.09 KB, patch)
2023-12-01 20:17 UTC, Salah Ghedda
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Salah Ghedda 2023-10-03 15:08:35 UTC
Instead of deleting one list at a time, it's more helpful to be able to delete multiple lists at once by adding checkboxes for each list along with a button (at the bottom or top of the page) to enable the deletion of multiple lists at once.
Comment 1 Salah Ghedda 2023-10-04 19:17:04 UTC
Created attachment 156553 [details] [review]
Bug 34977: The "Patron Lists" only allows deleting one list at a time

In the patrons lists, it's only possible to delete on list at a time. This patch add the possibility to select lists and delete them at once.

TEST PLAN
1. Apply the patch.
2. Create at least 2 patron lists (Navigate to Tools > Patron lists > New patron list).
3. Select the lists you want to delete.
4. Click the "Delete selected lists" button.
5. Confirm that the selected lists have been deleted.
6. Ensure that the button cannot be used if no list is selected.
Comment 2 Salah Ghedda 2023-10-04 19:44:44 UTC
Created attachment 156554 [details] [review]
Bug 34977: The "Patron Lists" only allows deleting one list at a time

In the patrons lists, it's only possible to delete one list at a time. This patch add the possibility to select lists and delete them at once.

TEST PLAN
1. Apply the patch.
2. Create at least 2 patron lists (Navigate to Tools > Patron lists > New patron list).
3. Select the lists you want to delete.
4. Click the "Delete selected lists" button.
5. Confirm that the selected lists have been deleted.
6. Ensure that the button cannot be used if no list is selected.
Comment 3 David Nind 2023-10-04 22:13:02 UTC
Created attachment 156562 [details] [review]
Bug 34977: The "Patron Lists" only allows deleting one list at a time

In the patrons lists, it's only possible to delete on list at a time. This patch add the possibility to select lists and delete them at once.

TEST PLAN
1. Apply the patch.
2. Create at least 2 patron lists (Navigate to Tools > Patron lists > New patron list).
3. Select the lists you want to delete.
4. Click the "Delete selected lists" button.
5. Confirm that the selected lists have been deleted.
6. Ensure that the button cannot be used if no list is selected.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Kyle M Hall 2023-11-03 16:16:10 UTC
Created attachment 158349 [details] [review]
Bug 34977: The "Patron Lists" only allows deleting one list at a time

In the patrons lists, it's only possible to delete on list at a time. This patch add the possibility to select lists and delete them at once.

TEST PLAN
1. Apply the patch.
2. Create at least 2 patron lists (Navigate to Tools > Patron lists > New patron list).
3. Select the lists you want to delete.
4. Click the "Delete selected lists" button.
5. Confirm that the selected lists have been deleted.
6. Ensure that the button cannot be used if no list is selected.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Kyle M Hall 2023-11-03 16:16:24 UTC
Created attachment 158350 [details] [review]
Bug 34977: (QA follow-up) Tidy code

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Kyle M Hall 2023-11-03 16:17:47 UTC
Would be nice if there was a select all button, but not a blocker
Comment 7 Tomás Cohen Arazi 2023-11-08 14:42:58 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 8 Fridolin Somers 2023-11-11 01:13:47 UTC
Enhancement not pushed to 23.05.x
Comment 9 Salah Ghedda 2023-12-01 20:17:12 UTC
Created attachment 159483 [details] [review]
Bug 34977: The "Patron Lists" only allows deleting one list at a time

In the patrons lists, it's only possible to delete on list at a time. This patch add the possibility to select lists and delete them at once.

TEST PLAN
1. Apply the patch.
2. Create at least 2 patron lists (Navigate to Tools > Patron lists > New patron list).
3. Select the lists you want to delete.
4. Click the "Delete selected lists" button.
5. Confirm that the selected lists have been deleted.
6. Ensure that the button cannot be used if no list is selected.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 10 Salah Ghedda 2023-12-01 20:17:15 UTC
Created attachment 159484 [details] [review]
Bug 34977: (QA follow-up) Tidy code

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 11 Salah Ghedda 2023-12-01 20:17:41 UTC
Rebased
Comment 12 Jonathan Druart 2023-12-13 15:19:44 UTC
-                return confirmDelete( _("Are you sure you want to delete the list %s?").format(list) );
+                return confirmDelete( _("Are you sure you want to delete the list %s?").format(list));

This change is wrong, unnecessary and causes conflict! Please avoid them and catch them before push!
Comment 13 Phan Tung Bui 2024-02-19 18:40:55 UTC
Bug 34977 prevented users from deleting multiple patron lists from the 2nd page onwards. Please check bug 36132 for more details
Comment 14 Phan Tung Bui 2024-02-19 18:41:13 UTC
Bug 34977 prevented users from deleting multiple patron lists from the 2nd page onwards. Please check bug 36132 for more details