Bug 35003 - Holds with cancellation requests table on waitingreserves.tt does not filter by branch
Summary: Holds with cancellation requests table on waitingreserves.tt does not filter ...
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Lucas Gass
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-06 15:14 UTC by Lucas Gass
Modified: 2023-11-13 15:23 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.06,22.11.12


Attachments
Bug 35003: Make cancelled hold requests filter by branch (1.48 KB, patch)
2023-10-06 15:18 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 35003: Make cancelled hold requests filter by branch (1.53 KB, patch)
2023-10-25 20:05 UTC, David Nind
Details | Diff | Splinter Review
Bug 35003: Make cancelled hold requests filter by branch (1.62 KB, patch)
2023-10-27 09:35 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2023-10-06 15:14:41 UTC
On the waitingreserves.tt page the Holds with cancellation requests table does not initial filter by branch. The holds waiting and holds over table both do this.

To recreate: 
1. Make sure you have the "Default waiting hold cancellation policy" set to allow via circulation rules.
2. Make several holds at different branches  holds and set them to waiting
3. Request to cancel those holds, making sure you cancel some for different branches.
4. Go to waitingreserves.tt and notice that you see all of the holds from all branches.
Comment 1 Lucas Gass 2023-10-06 15:18:47 UTC
Created attachment 156633 [details] [review]
Bug 35003: Make cancelled hold requests filter by branch

To recreate:
1. Make sure you have the "Default waiting hold cancellation policy" set to allow via circulation rules.
2. Make several holds at different branches  holds and set them to waiting
3. Request to cancel those holds, making sure you cancel some for different branches.
4. Go to waitingreserves.tt and notice that you see all of the holds from all branches.
5. APPLY PATCH and restart services
6. Vist the waitingreserves.tt page and notice that the "Holds with cancellation requests" table can now filters by branch.
7. Use the "View all libraries" and make sure you can see all the holds with a cancellation request.
Comment 2 David Nind 2023-10-25 20:05:58 UTC
Created attachment 157874 [details] [review]
Bug 35003: Make cancelled hold requests filter by branch

To recreate:
1. Make sure you have the "Default waiting hold cancellation policy" set to allow via circulation rules.
2. Make several holds at different branches  holds and set them to waiting
3. Request to cancel those holds, making sure you cancel some for different branches.
4. Go to waitingreserves.tt and notice that you see all of the holds from all branches.
5. APPLY PATCH and restart services
6. Vist the waitingreserves.tt page and notice that the "Holds with cancellation requests" table can now filters by branch.
7. Use the "View all libraries" and make sure you can see all the holds with a cancellation request.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Marcel de Rooy 2023-10-27 09:35:03 UTC
Created attachment 157975 [details] [review]
Bug 35003: Make cancelled hold requests filter by branch

To recreate:
1. Make sure you have the "Default waiting hold cancellation policy" set to allow via circulation rules.
2. Make several holds at different branches  holds and set them to waiting
3. Request to cancel those holds, making sure you cancel some for different branches.
4. Go to waitingreserves.tt and notice that you see all of the holds from all branches.
5. APPLY PATCH and restart services
6. Vist the waitingreserves.tt page and notice that the "Holds with cancellation requests" table can now filters by branch.
7. Use the "View all libraries" and make sure you can see all the holds with a cancellation request.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Tomás Cohen Arazi 2023-10-27 19:55:06 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-11-08 07:41:20 UTC
Pushed to 23.05.x for 23.05.06
Comment 6 Matt Blenkinsop 2023-11-13 15:23:25 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x