Bug 35007 - Configure self checkout tables consistently
Summary: Configure self checkout tables consistently
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Self checkout (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Nick Clemens (kidclamp)
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2023-10-08 18:51 UTC by David Nind
Modified: 2023-11-09 16:01 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Screenshot showing DataTables controls (57.05 KB, image/png)
2023-10-09 16:07 UTC, Owen Leonard
Details
Bug 35007: Configure self checkout tables consistently (11.46 KB, patch)
2023-10-10 17:47 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35007: Configure self checkout tables consistently (11.51 KB, patch)
2023-10-10 18:47 UTC, David Nind
Details | Diff | Splinter Review
Bug 35007: Configure self checkout tables consistently (11.58 KB, patch)
2023-10-11 18:19 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 35007: Configure self checkout tables consistently (11.67 KB, patch)
2023-10-25 12:23 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Nind 2023-10-08 18:51:14 UTC
In the OPAC self checkout system, the tables in the tabs (such as Checkouts, Holds, and Charges) have different header row colours.

For the checkouts tab, the header row is consistent with other tables in the OPAC.

For the other tabs (such as Checkouts and Holds), the table heading row has a white background.

To replicate (using KTD):
1. Enable the SelfCheckInModule and WebBasedSelfCheck system preferences (if not already enabled).
2. Check out some items to the koha user.
3. Place some holds for the koha user.
4. Add a charge to the koha user (Patrons > koha (42) > Accounting > Create manual invoice).
5. Go to the self checkout system page: <yourlocalhostname>:8080/cgi-bin/koha/sco/sco-main.pl
6. Log in as the koha user
7. Note that:
   - for the Checkouts tab: the table has a coloured background and looks consistent with other tables in the OPAC
   - for the other tabs (Holds and Charges): the table heading row for both tables has a white background
Comment 1 Owen Leonard 2023-10-09 16:07:03 UTC
Created attachment 156754 [details]
Screenshot showing DataTables controls

The table style differences on this page are due to the fact that the checkouts table is a DataTable and the others are not. We could modify the CSS so that they match, but I think we might like to make the holds and account tables DataTables.

Since I'm copying DT initialization from opac-user.tt I wonder: Should we include copy/csv/print buttons like we do on that page? See attached screenshot.
Comment 2 David Nind 2023-10-09 18:03:10 UTC
(In reply to Owen Leonard from comment #1)
> 
> Since I'm copying DT initialization from opac-user.tt I wonder: Should we
> include copy/csv/print buttons like we do on that page? See attached
> screenshot.

It wouldn't hurt, but I'm not sure whether a patron would use them - but you never know!
Comment 3 Owen Leonard 2023-10-10 17:47:49 UTC Comment hidden (obsolete)
Comment 4 David Nind 2023-10-10 18:47:57 UTC Comment hidden (obsolete)
Comment 5 David Nind 2023-10-10 18:48:36 UTC
Thanks Owen!
Comment 6 Nick Clemens (kidclamp) 2023-10-11 18:19:24 UTC Comment hidden (obsolete)
Comment 7 Nick Clemens (kidclamp) 2023-10-11 18:20:36 UTC
We may want a way to easily hide the table controls, not sure if there is a simple CSS, but some libraries won't have a printer hooked up, or the table might not print nice to a receipt printer, but I don't think including by default hurts
Comment 8 Tomás Cohen Arazi 2023-10-20 20:13:10 UTC
Please rebase ASAP. Thanks!
Comment 9 Owen Leonard 2023-10-25 12:23:58 UTC
Created attachment 157794 [details] [review]
Bug 35007: Configure self checkout tables consistently

This patch makes some updates to the self checkout page so that
checkouts, holds, and account tabs are consistent with each other, with
the same DataTables configuration.

Included in the DataTables configuration are the same options we use on
the OPAC's user summary page to show controls for copy, CSV, and print.

Also changed: Some extra markup is removed from holds-table.inc, markup
which was used to show table information responsively before we started
using the DataTables responsive plugin.

To test, apply the patch and log into the self checkout system as a user
with checkouts, holds, and present or past charges.

Compare the checkouts, holds, and charges tabs to confirm that the
tables look correct and work correctly. Test that the copy, CSV, and
print controls, and the search and clear filter functions. Test that
each table responds correctly at various browser widths.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 10 Tomás Cohen Arazi 2023-10-25 13:36:23 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 11 Fridolin Somers 2023-10-26 07:55:49 UTC
Conflicts when backport 23.05.x on :
koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc
koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt

Please create a dedicated patch if backport is wanted.
Comment 12 Owen Leonard 2023-11-09 16:01:25 UTC
(In reply to Nick Clemens from comment #7)
> We may want a way to easily hide the table controls, not sure if there is a
> simple CSS

Putting this in SCOUserCSS seems to work:

.buttons-copy,
.buttons-csv,
.buttons-print {
    display: none;
}

or if you don't want the search filter either:

.table_controls {
   display: none;
}