Bug 35033 - Add a validation for biblioitems in about/system information
Summary: Add a validation for biblioitems in about/system information
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: About (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Blou
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-11 15:51 UTC by Blou
Modified: 2023-11-13 15:29 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.06,22.11.12


Attachments
Bug 35033: Add a validation for biblioitems in about/system information (3.84 KB, patch)
2023-10-11 15:59 UTC, Blou
Details | Diff | Splinter Review
Bug 35033: Add a validation for biblioitems in about/system information (3.84 KB, patch)
2023-10-11 16:04 UTC, Blou
Details | Diff | Splinter Review
Bug 35033: Add a validation for biblioitems in about/system information (3.89 KB, patch)
2023-10-22 18:40 UTC, David Nind
Details | Diff | Splinter Review
Bug 35033: Add a validation for biblioitems in about/system information (3.94 KB, patch)
2023-10-30 17:59 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review
Bug 35033: (QA follow-up): tidy up code (1.18 KB, patch)
2023-10-30 17:59 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Blou 2023-10-11 15:51:05 UTC
In the About section, under the System information tab, we get validation between issues, borrowers, biblio, items, reserves tables, and their deleted/old counterpart.

But there's no validation for biblioitems.  And yes, on issues during creation, most probably, discrepencies do occur, as I've now discovered on 10 different clients.

This patch will simply add the same test (and display) as the others, but for biblioitems.

Testing
0) Create a simple biblio entry through cataloguing. Note the biblioitemnumber created.
1) Insert a dummy entry in deletedbiblioitem using the biblioitemnumber.  An simple SQL will do
insert into deletedbiblioitems select * from biblioitems where biblioitemnumber = GIVENbin;
2) Go to about, see there's no warning in systeminformation.
3) apply the patch, validate that an error appears.
Comment 1 Blou 2023-10-11 15:59:42 UTC
Created attachment 156852 [details] [review]
Bug 35033: Add a validation for biblioitems in about/system information

In the About section, under the System information tab, we get validation between
issues, borrowers, biblio, items, reserves tables, and their deleted/old counterpart.

But there's no validation for biblioitems.

This patch will simply add the same test (and display) as the others, but for biblioitems.

Testing
0) Create a simple biblio entry through cataloguing. Note the biblioitemnumber created.
1) Insert a dummy entry in deletedbiblioitem using the biblioitemnumber.  An simple SQL will do
insert into deletedbiblioitems select * from biblioitems where biblioitemnumber = GIVENbin;
2) Go to about, see there's no warning in systeminformation.
3) apply the patch, validate that an error appears.
Comment 2 Blou 2023-10-11 16:04:59 UTC
Created attachment 156853 [details] [review]
Bug 35033: Add a validation for biblioitems in about/system information

In the About section, under the System information tab, we get validation between
issues, borrowers, biblio, items, reserves tables, and their deleted/old counterpart.

But there's no validation for biblioitems.

This patch will simply add the same test (and display) as the others, but for biblioitems.

Testing
0) Create a simple biblio entry through cataloguing. Note the biblioitemnumber created.
1) Insert a dummy entry in deletedbiblioitem using the biblioitemnumber.  An simple SQL will do
insert into deletedbiblioitems select * from biblioitems where biblioitemnumber = GIVENbin;
2) Go to about, see there's no warning in systeminformation.
3) apply the patch, validate that an error appears.
Comment 3 David Nind 2023-10-22 18:40:38 UTC
Created attachment 157621 [details] [review]
Bug 35033: Add a validation for biblioitems in about/system information

In the About section, under the System information tab, we get validation between
issues, borrowers, biblio, items, reserves tables, and their deleted/old counterpart.

But there's no validation for biblioitems.

This patch will simply add the same test (and display) as the others, but for biblioitems.

Testing
0) Create a simple biblio entry through cataloguing. Note the biblioitemnumber created.
1) Insert a dummy entry in deletedbiblioitem using the biblioitemnumber.  An simple SQL will do
insert into deletedbiblioitems select * from biblioitems where biblioitemnumber = GIVENbin;
2) Go to about, see there's no warning in systeminformation.
3) apply the patch, validate that an error appears.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Victor Grousset/tuxayo 2023-10-30 17:59:13 UTC
Created attachment 158098 [details] [review]
Bug 35033: Add a validation for biblioitems in about/system information

In the About section, under the System information tab, we get validation between
issues, borrowers, biblio, items, reserves tables, and their deleted/old counterpart.

But there's no validation for biblioitems.

This patch will simply add the same test (and display) as the others, but for biblioitems.

Testing
0) Create a simple biblio entry through cataloguing. Note the biblioitemnumber created.
1) Insert a dummy entry in deletedbiblioitem using the biblioitemnumber.  An simple SQL will do
insert into deletedbiblioitems select * from biblioitems where biblioitemnumber = GIVENbin;
2) Go to about, see there's no warning in systeminformation.
3) apply the patch, validate that an error appears.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 5 Victor Grousset/tuxayo 2023-10-30 17:59:17 UTC
Created attachment 158099 [details] [review]
Bug 35033: (QA follow-up): tidy up code
Comment 6 Victor Grousset/tuxayo 2023-10-30 17:59:39 UTC
Works, makes sense, QA script happy, code looks good, passing QA :)
Comment 7 Tomás Cohen Arazi 2023-10-31 14:06:46 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 8 Fridolin Somers 2023-11-08 08:29:44 UTC
Pushed to 23.05.x for 23.05.06
Comment 9 Matt Blenkinsop 2023-11-13 15:29:19 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x