Bug 35036 - Incorrect chopping to punctuation in 246 fields
Summary: Incorrect chopping to punctuation in 246 fields
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Bibliographic data support (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Lucas Gass
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-11 16:41 UTC by Lucas Gass
Modified: 2023-10-19 20:33 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 35036: Do not remove punctuaction of 246 fields (3.57 KB, patch)
2023-10-11 22:12 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 35036: Do not remove punctuaction of 246 fields (3.89 KB, patch)
2023-10-11 22:13 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 35036: Remove extra puncuation from staff results page (1.28 KB, patch)
2023-10-11 22:23 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 35036: Do not remove punctuaction of 246 fields (3.96 KB, patch)
2023-10-12 16:28 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 35036: Remove extra puncuation from staff results page (1.36 KB, patch)
2023-10-12 16:28 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 35036: Remove extra puncuation from staff results page (1.39 KB, patch)
2023-10-12 19:17 UTC, ByWater Sandboxes
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2023-10-11 16:41:03 UTC
To recreate:

1. Add a 245$b to a record that ends with punctuation. ie. 'E.B.'
2. Go the record detail page on both the staff interface and OPAC.
3. The last period does not display.
Comment 1 Lucas Gass 2023-10-11 22:08:55 UTC
I meant 246$b, not 245.
Comment 2 Lucas Gass 2023-10-11 22:12:14 UTC
Created attachment 156881 [details] [review]
Bug 35036: Do not remove punctuaction of 246 fields
Comment 3 Lucas Gass 2023-10-11 22:13:32 UTC
Created attachment 156882 [details] [review]
Bug 35036: Do not remove punctuaction of 246 fields

To test:
1. Add a 245$b to a record that ends with punctuation. ie. 'E.B.'
2. Go the record detail page on both the staff interface and OPAC.
3. The last period does not display.
4. APPLY patch and restart services
5. Look at the OPAC detail and staff interface detail pages again, the display should include punctuation
Comment 4 Lucas Gass 2023-10-11 22:23:59 UTC
Created attachment 156883 [details] [review]
Bug 35036: Remove extra puncuation from staff results page

To test:
1. Look at the a results set on the staff interface that contains titles with a 246.
2. It now contains too much puncuation.
3. Apply patch
4. It now looks like the other pages.
Comment 5 Matt Blenkinsop 2023-10-12 16:28:33 UTC
Created attachment 156986 [details] [review]
Bug 35036: Do not remove punctuaction of 246 fields

To test:
1. Add a 245$b to a record that ends with punctuation. ie. 'E.B.'
2. Go the record detail page on both the staff interface and OPAC.
3. The last period does not display.
4. APPLY patch and restart services
5. Look at the OPAC detail and staff interface detail pages again, the display should include punctuation

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 6 Matt Blenkinsop 2023-10-12 16:28:35 UTC
Created attachment 156987 [details] [review]
Bug 35036: Remove extra puncuation from staff results page

To test:
1. Look at the a results set on the staff interface that contains titles with a 246.
2. It now contains too much puncuation.
3. Apply patch
4. It now looks like the other pages.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 7 ByWater Sandboxes 2023-10-12 19:17:51 UTC
Created attachment 156991 [details] [review]
Bug 35036: Remove extra puncuation from staff results page

To test:
1. Look at the a results set on the staff interface that contains titles with a 246.
2. It now contains too much puncuation.
3. Apply patch
4. It now looks like the other pages.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Esther <esther@bywatersolutions.com>
Comment 8 Katrin Fischer 2023-10-14 19:10:47 UTC
There are some issues with this this patch set:

* If a library does the ending . at the end of fields, it will now keep showing. As we always always remove it, that will be inconsistent.

The chop punctuation is thought to remove that ending dot, but the problem is that we cannot distinguish between an abbreviation dot and the field ending punctuation. This is not only a problem for 246, it's a general known issue.

* Removing the common separator | on the staff results page doesn't give the expected result (missing space at least, but also no longer consistent)

Other title: TitleA : RemainderA.TitleB : RamainderB.

I think if we want to change this, we need to find a general solution and apply it to more than only the 246 field. I believe this needs more thought.
Comment 9 Lucas Gass 2023-10-18 22:41:33 UTC
This is not only a problem for 246, it's a general known
> issue.

Is there an open bug for the general issue?
Comment 10 Lucas Gass 2023-10-18 22:46:14 UTC
> I think if we want to change this, we need to find a general solution and
> apply it to more than only the 246 field. I believe this needs more thought.

Can we at least make the logic behind the displaying of the 246 consistent for staff detail/results and OPAC detail/results? 

Right now we do something different in each of the 4 XSLT files.
Comment 11 Katrin Fischer 2023-10-19 20:33:31 UTC
(In reply to Lucas Gass from comment #9)
> This is not only a problem for 246, it's a general known
> > issue.
> 
> Is there an open bug for the general issue?

I already linked it: bug 24833

Sorry I that came across kind of harsh before - of course I think consistency would be good.