Bug 35037 - Revise the appearance of the last patron button
Summary: Revise the appearance of the last patron button
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Kyle M Hall
URL:
Keywords:
Depends on: 21246
Blocks:
  Show dependency treegraph
 
Reported: 2023-10-11 17:48 UTC by Owen Leonard
Modified: 2023-10-25 06:27 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 35037: Revise the appearance of the last patron button (4.54 KB, patch)
2023-10-11 18:01 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35037: Revise the appearance of the last patron button (4.59 KB, patch)
2023-10-11 21:42 UTC, David Nind
Details | Diff | Splinter Review
Bug 35037: (follow-up) Minor adjustments to margins and padding (1.30 KB, patch)
2023-10-12 10:39 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35037: Revise the appearance of the last patron button (4.65 KB, patch)
2023-10-13 13:25 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 35037: (follow-up) Minor adjustments to margins and padding (1.36 KB, patch)
2023-10-13 13:25 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 35037: Revise the appearance of the last patron button (4.70 KB, patch)
2023-10-13 16:55 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 35037: (follow-up) Minor adjustments to margins and padding (1.41 KB, patch)
2023-10-13 16:55 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-10-11 17:48:35 UTC
I think the last patron button looks too big following the changes made in Bug 21246. I would like to propose a less obtrusive version.
Comment 1 Owen Leonard 2023-10-11 18:01:51 UTC
Created attachment 156872 [details] [review]
Bug 35037: Revise the appearance of the last patron button

Following Bug 21246 I find the button to be too obtrusive. This patch
makes CSS changes to the style of the "Last patron" button shown in the
staff interface when the "showLastPatron" system preference is enabled.

To test, apply the patch and rebuild the staff interface CSS.

- Enable the showLastPatron system preference if necessary.
- Go to Circulation in the staff interface and check out to a patron.
- A "Last patron" button should appear on the right-hand end of the
  breadcrumbs bar.
- Check that the link, dropdown button, and dropdown menu look good.
Comment 2 Kyle M Hall 2023-10-11 18:28:17 UTC
This looks pretty good! I think it could use a bit of whitespace between the arrow and the help link to avoid accidental clicks.
Comment 3 David Nind 2023-10-11 21:42:40 UTC
Created attachment 156880 [details] [review]
Bug 35037: Revise the appearance of the last patron button

Following Bug 21246 I find the button to be too obtrusive. This patch
makes CSS changes to the style of the "Last patron" button shown in the
staff interface when the "showLastPatron" system preference is enabled.

To test, apply the patch and rebuild the staff interface CSS.

- Enable the showLastPatron system preference if necessary.
- Go to Circulation in the staff interface and check out to a patron.
- A "Last patron" button should appear on the right-hand end of the
  breadcrumbs bar.
- Check that the link, dropdown button, and dropdown menu look good.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2023-10-11 21:44:31 UTC
It looks great to me! 

I like that the name + card number are now aligned properly and aren't cut off.

Maybe some more space between the dropdown list and the Help link, but a great improvement!
Comment 5 Jonathan Druart 2023-10-12 04:04:42 UTC
Can you add more space please? :)
Comment 6 Owen Leonard 2023-10-12 10:39:24 UTC
Created attachment 156936 [details] [review]
Bug 35037: (follow-up) Minor adjustments to margins and padding
Comment 7 Kyle M Hall 2023-10-13 13:25:36 UTC
Created attachment 157085 [details] [review]
Bug 35037: Revise the appearance of the last patron button

Following Bug 21246 I find the button to be too obtrusive. This patch
makes CSS changes to the style of the "Last patron" button shown in the
staff interface when the "showLastPatron" system preference is enabled.

To test, apply the patch and rebuild the staff interface CSS.

- Enable the showLastPatron system preference if necessary.
- Go to Circulation in the staff interface and check out to a patron.
- A "Last patron" button should appear on the right-hand end of the
  breadcrumbs bar.
- Check that the link, dropdown button, and dropdown menu look good.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 8 Kyle M Hall 2023-10-13 13:25:42 UTC
Created attachment 157086 [details] [review]
Bug 35037: (follow-up) Minor adjustments to margins and padding

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 9 Lucas Gass 2023-10-13 16:55:54 UTC
Created attachment 157130 [details] [review]
Bug 35037: Revise the appearance of the last patron button

Following Bug 21246 I find the button to be too obtrusive. This patch
makes CSS changes to the style of the "Last patron" button shown in the
staff interface when the "showLastPatron" system preference is enabled.

To test, apply the patch and rebuild the staff interface CSS.

- Enable the showLastPatron system preference if necessary.
- Go to Circulation in the staff interface and check out to a patron.
- A "Last patron" button should appear on the right-hand end of the
  breadcrumbs bar.
- Check that the link, dropdown button, and dropdown menu look good.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 10 Lucas Gass 2023-10-13 16:55:57 UTC
Created attachment 157131 [details] [review]
Bug 35037: (follow-up) Minor adjustments to margins and padding

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 11 Tomás Cohen Arazi 2023-10-17 17:48:19 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 12 Fridolin Somers 2023-10-25 06:27:06 UTC
Enhancement not pushed to 23.05.x