Bug 35059 - Display item's shelving location on the items tab
Summary: Display item's shelving location on the items tab
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-15 08:39 UTC by Michaela Sieber
Modified: 2023-12-14 21:41 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact: Caroline Cyr La Rose
Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/792
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 35059: Display item location on item details (catalogue/moredetail.pl) (2.94 KB, patch)
2023-10-16 14:51 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35059: Display item location on item details (catalogue/moredetail.pl) (2.99 KB, patch)
2023-10-16 15:12 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 35059: Display item location on item details (catalogue/moredetail.pl) (3.05 KB, patch)
2023-10-16 19:28 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 35059: (Follow-up) Get authorised value description from koha field (1.38 KB, patch)
2023-10-28 22:32 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Michaela Sieber 2023-10-15 08:39:37 UTC
We miss the location on the item details page (catalogue/moredetail.pl)

item type, collection, callnumber and copynumber are displayed but the location is missing
Comment 1 Katrin Fischer 2023-10-16 07:16:56 UTC
23.05.04 appears to be ok. Which version did this problem appear in?
Comment 2 Katrin Fischer 2023-10-16 07:17:42 UTC
Did you hide the home library in table configuration? In the staff interface it's not possible (yet) to display the location as a separate column.
Comment 3 Katrin Fischer 2023-10-16 08:39:03 UTC
(In reply to Katrin Fischer from comment #2)
> Did you hide the home library in table configuration? In the staff interface
> it's not possible (yet) to display the location as a separate column.

Ah, I realized that this is an enhancement request for the display on the "items tab"
Comment 4 Owen Leonard 2023-10-16 14:51:42 UTC
Created attachment 157199 [details] [review]
Bug 35059: Display item location on item details (catalogue/moredetail.pl)

This patch updates the item details template so that item location is
displayed along with information like collection and call number.

The template has also been modified to correct the label "Item
callnumber" to "Item call number."

To test, apply the patch and update an item, if necessary, to add a
shelving location.

- View the bibliographic details page of the record.
- Click the "Items" tab in the left-hand sidebar menu.
- Under the "Item information" subheading you should see a line for
  "Shelving location" just after the "Item call number" line.
- Confirm that the correct item location description is shown.
Comment 5 ByWater Sandboxes 2023-10-16 15:12:23 UTC
Created attachment 157202 [details] [review]
Bug 35059: Display item location on item details (catalogue/moredetail.pl)

This patch updates the item details template so that item location is
displayed along with information like collection and call number.

The template has also been modified to correct the label "Item
callnumber" to "Item call number."

To test, apply the patch and update an item, if necessary, to add a
shelving location.

- View the bibliographic details page of the record.
- Click the "Items" tab in the left-hand sidebar menu.
- Under the "Item information" subheading you should see a line for
  "Shelving location" just after the "Item call number" line.
- Confirm that the correct item location description is shown.

Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Comment 6 Michaela Sieber 2023-10-16 15:17:52 UTC
Thanks Owen!

For everybody who is interested, please note: the displayed location is the item field 'location' and not 'permanent_location'
Comment 7 Katrin Fischer 2023-10-16 19:28:32 UTC
Created attachment 157207 [details] [review]
Bug 35059: Display item location on item details (catalogue/moredetail.pl)

This patch updates the item details template so that item location is
displayed along with information like collection and call number.

The template has also been modified to correct the label "Item
callnumber" to "Item call number."

To test, apply the patch and update an item, if necessary, to add a
shelving location.

- View the bibliographic details page of the record.
- Click the "Items" tab in the left-hand sidebar menu.
- Under the "Item information" subheading you should see a line for
  "Shelving location" just after the "Item call number" line.
- Confirm that the correct item location description is shown.

Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Tomás Cohen Arazi 2023-10-25 13:36:27 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 9 Fridolin Somers 2023-10-26 08:07:03 UTC
+ [% AuthorisedValues.GetByCode( 'LOC', ITEM_DAT.location ) | html %]

Oh since Bug 26323 we use other syntax :
  [% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.location', authorised_value => item.location ) | html %]

items.location may no use AV 'LOC'.

Also :
Many places use class="shelvingloc" for CSS tuning.

Example :
https://git.koha-community.org/Koha-community/Koha/src/commit/474d6c7462c055c11e58986d837d8087f74562d9/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt#L374
Comment 10 Katrin Fischer 2023-10-28 22:32:55 UTC
Created attachment 158017 [details] [review]
Bug 35059: (Follow-up) Get authorised value description from koha field
Comment 11 Katrin Fischer 2023-10-28 22:33:58 UTC
Provided and tested the follow-up as suggested by Frido.
Comment 12 Tomás Cohen Arazi 2023-11-06 11:17:17 UTC
(In reply to Katrin Fischer from comment #10)
> Bug 35059: (Follow-up) Get authorised value description from koha field

              ^^^^^^^^^^

Heh.
Comment 13 Katrin Fischer 2023-11-06 19:35:56 UTC
The capital F making the test tools fail?
Comment 14 Fridolin Somers 2023-11-10 07:02:32 UTC
Enhancement not pushed to 23.05.x