Bug 35069 - Items needed column on circ/reserveratios.pl does not sort properly
Summary: Items needed column on circ/reserveratios.pl does not sort properly
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Emily Lamancusa (emlam)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-16 23:02 UTC by Lucas Gass (lukeg)
Modified: 2024-07-04 20:40 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.05,22.11.12
Circulation function:

Attachments
Bug 35069: Fix holds to buy column sorting (1.48 KB, patch)
2023-10-16 23:04 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 35069: Fix hold ratios items needed column sorting (1.54 KB, patch)
2023-10-17 11:32 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 35069: Fix hold ratios items needed column sorting (1.61 KB, patch)
2023-10-17 19:52 UTC, Emily Lamancusa (emlam) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2023-10-16 23:02:13 UTC 
To recreate:

1. Make a lot of holds. 
2. On some holds have a high enough holds/copies ratio so the "Items to buy column" has values greater than 10.
3. Sort by that column. Notice the copies with an "Items to buy" higher than 10 do not get sorted correctly.
Comment 1 Lucas Gass (lukeg) 2023-10-16 23:04:48 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2023-10-17 11:32:37 UTC 
Created attachment 157225 [details] [review]
Bug 35069: Fix hold ratios items needed column sorting

This patch adds the data-sort attribute to the "Items needed" column to
ensure proper sorting.

To test:
1. Make a lot of holds.
2. On some holds have a high enough holds/copies ratio so the "Items
   needed" has values greater than 10.
3. Sort by that column. Notice the copies with an "Items needed" higher
   than 10 do not get sorted correctly.
4. APPLY PATCH
5. Try steps 1 -3 again. Everything should sort properly.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Emily Lamancusa (emlam) 2023-10-17 19:52:14 UTC 
Created attachment 157287 [details] [review]
Bug 35069: Fix hold ratios items needed column sorting

This patch adds the data-sort attribute to the "Items needed" column to
ensure proper sorting.

To test:
1. Make a lot of holds.
2. On some holds have a high enough holds/copies ratio so the "Items
   needed" has values greater than 10.
3. Sort by that column. Notice the copies with an "Items needed" higher
   than 10 do not get sorted correctly.
4. APPLY PATCH
5. Try steps 1 -3 again. Everything should sort properly.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-10-25 14:10:04 UTC 
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-10-26 08:23:53 UTC 
Pushed to 23.05.x for 23.05.05
Comment 6 Matt Blenkinsop 2023-11-13 15:11:29 UTC 
Nice work everyone!

Pushed to oldstable for 22.11.x