Bug 35078 - Invalid HTML in OpacShowSavings system preference
Summary: Invalid HTML in OpacShowSavings system preference
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 31051
Blocks:
  Show dependency treegraph
 
Reported: 2023-10-17 13:48 UTC by Caroline Cyr La Rose
Modified: 2023-11-13 15:16 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.06


Attachments
Bug 35078: Remove invalid HTML from OpacShowSavings system preference (2.25 KB, patch)
2023-10-17 13:59 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35078: Remove invalid HTML from OpacShowSavings system preference (2.32 KB, patch)
2023-10-17 14:07 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 35078: Remove invalid HTML from OpacShowSavings system preference (2.38 KB, patch)
2023-10-18 23:55 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-10-17 13:48:27 UTC
In the OpacShowSavings system preference, there are some <em> tags that are shown rather than making the text italic.

To test:
1. Go to Administration > System preferences
2. Search for OPACShowSavings
3. Open the drop-down menu
--> The <em> tags are displayed
Comment 1 Owen Leonard 2023-10-17 13:59:35 UTC
Created attachment 157251 [details] [review]
Bug 35078: Remove invalid HTML from OpacShowSavings system preference

The options defined for the OpacShowSavings system preference contain
HTML: "on patron's checkout history page (the system preference
<em>opacreadinghistory</em> must be enabled)". This text ends up in an
<option> tag, and even though the form is rendered using the
multiple-select plugin the HTML still won't render and should
be removed.

To test, apply the patch and restart all.

- Go to Administration -> System preferences and search for
  "OpacShowSavings"
- Check the dropdown of options on the preference. The system
  preference names referred to should now be single-quoted instead of
  wrapped in visible <em> tags.
- Confirm that the preference still works correctly.
Comment 2 Caroline Cyr La Rose 2023-10-17 14:07:13 UTC
Created attachment 157252 [details] [review]
Bug 35078: Remove invalid HTML from OpacShowSavings system preference

The options defined for the OpacShowSavings system preference contain
HTML: "on patron's checkout history page (the system preference
<em>opacreadinghistory</em> must be enabled)". This text ends up in an
<option> tag, and even though the form is rendered using the
multiple-select plugin the HTML still won't render and should
be removed.

To test, apply the patch and restart all.

- Go to Administration -> System preferences and search for
  "OpacShowSavings"
- Check the dropdown of options on the preference. The system
  preference names referred to should now be single-quoted instead of
  wrapped in visible <em> tags.
- Confirm that the preference still works correctly.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 3 Caroline Cyr La Rose 2023-10-17 14:11:36 UTC
Also tested the translation and it looks good!
Comment 4 Victor Grousset/tuxayo 2023-10-18 23:55:08 UTC
Created attachment 157366 [details] [review]
Bug 35078: Remove invalid HTML from OpacShowSavings system preference

The options defined for the OpacShowSavings system preference contain
HTML: "on patron's checkout history page (the system preference
<em>opacreadinghistory</em> must be enabled)". This text ends up in an
<option> tag, and even though the form is rendered using the
multiple-select plugin the HTML still won't render and should
be removed.

To test, apply the patch and restart all.

- Go to Administration -> System preferences and search for
  "OpacShowSavings"
- Check the dropdown of options on the preference. The system
  preference names referred to should now be single-quoted instead of
  wrapped in visible <em> tags.
- Confirm that the preference still works correctly.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 5 Victor Grousset/tuxayo 2023-10-18 23:56:04 UTC
Works, makes sense, QA script happy, code looks good, passing QA :)
Comment 6 Tomás Cohen Arazi 2023-10-19 19:02:25 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 7 Fridolin Somers 2023-11-08 07:12:20 UTC
Pushed to 23.05.x for 23.05.06
Comment 8 Matt Blenkinsop 2023-11-13 15:16:42 UTC
Dependency missing for 22.11.x - not backporting