A simple ILL request that has a lot of fields empty is still presented with a very long "Manage request" page. We could do with lighten the page a bit.
Created attachment 157458 [details] [review] Bug 35108: Hide optionally empty fields label entries, these are: orderid, biblio_id, batch already was the case, type, type_disclaimer_value, type_disclaimer_date, cost, price_paid, notesstaff, notesopac Test plan, k-t-d: 1) Install FreeForm and BLDSS backends, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-plus.sh) 2) Create a new FreeForm request, visit: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 5) Set type 'Book', put '42' in the cardnumber, and pick a library. Click 'create'. 6) Notice how there is a lot of unnecessary empty field entries 7) Apply patch, restart plack (koha-plack --restart kohadev) 8) Refresh the page, notice all the empty fields entries are no longer displayed
Created attachment 157463 [details] [review] Bug 35108: Move request id to page header Redundant information, can be moved to header for more visibility and less horizontal length
Created attachment 157464 [details] [review] Bug 35108: Hide optionally empty fields label entries, these are: orderid, biblio_id, batch already was the case, type, type_disclaimer_value, type_disclaimer_date, cost, price_paid, notesstaff, notesopac Test plan, k-t-d: 1) Install FreeForm and BLDSS backends, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-plus.sh) 2) Create a new FreeForm request, visit: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 5) Set type 'Book', put '42' in the cardnumber, and pick a library. Click 'create'. 6) Notice how there is a lot of unnecessary empty field entries 7) Apply patch, restart plack (koha-plack --restart kohadev) 8) Refresh the page, notice all the empty fields entries are no longer displayed
Created attachment 159657 [details] [review] Bug 35108: Move request id to page header Redundant information, can be moved to header for more visibility and less horizontal length
Created attachment 159658 [details] [review] Bug 35108: Hide optionally empty fields label entries, these are: orderid, biblio_id, batch already was the case, type, type_disclaimer_value, type_disclaimer_date, cost, price_paid, notesstaff, notesopac Test plan, k-t-d: 1) Install FreeForm and BLDSS backends, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-plus.sh) 2) Create a new FreeForm request, visit: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 5) Set type 'Book', put '42' in the cardnumber, and pick a library. Click 'create'. 6) Notice how there is a lot of unnecessary empty field entries 7) Apply patch, restart plack (koha-plack --restart kohadev) 8) Refresh the page, notice all the empty fields entries are no longer displayed
Created attachment 159688 [details] [review] Bug 35108: Move request id to page header Redundant information, can be moved to header for more visibility and less horizontal length Signed-off-by: David Nind <david@davidnind.com>
Created attachment 159689 [details] [review] Bug 35108: Hide optionally empty fields label entries, these are: orderid, biblio_id, batch already was the case, type, type_disclaimer_value, type_disclaimer_date, cost, price_paid, notesstaff, notesopac Test plan, k-t-d: 1) Install FreeForm and BLDSS backends, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-plus.sh) 2) Create a new FreeForm request, visit: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 5) Set type 'Book', put '42' in the cardnumber, and pick a library. Click 'create'. 6) Notice how there is a lot of unnecessary empty field entries 7) Apply patch, restart plack (koha-plack --restart kohadev) 8) Refresh the page, notice all the empty fields entries are no longer displayed Signed-off-by: David Nind <david@davidnind.com>
Created attachment 159752 [details] [review] Bug 35108: Move request id to page header Redundant information, can be moved to header for more visibility and less horizontal length Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 159753 [details] [review] Bug 35108: Hide empty fields on ILL manage request page Optionally empty fields are: orderid, biblio_id, batch, type, type_disclaimer_value, type_disclaimer_date, cost, price_paid, notesstaff, notesopac. Test plan, k-t-d: 1) Install FreeForm and BLDSS backends, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-plus.sh) 2) Create a new FreeForm request, visit: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 5) Set type 'Book', put '42' in the cardnumber, and pick a library. Click 'create'. 6) Notice how there is a lot of unnecessary empty field entries 7) Apply patch, restart plack (koha-plack --restart kohadev) 8) Refresh the page, notice all the empty fields entries are no longer displayed Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Simple trivial patch to improve display.. Passing QA, but the dependency still needs an QA stamp from someone else. I'll pass then mark as blocked whilst we wait for the dependency.
Hi Pedro, should be an easy rebase, but I want to keep moving right now - can you please take care of it?
Created attachment 165136 [details] [review] Bug 35108: Move request id to page header Redundant information, can be moved to header for more visibility and less horizontal length Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 165137 [details] [review] Bug 35108: Hide empty fields on ILL manage request page Optionally empty fields are: orderid, biblio_id, batch, type, type_disclaimer_value, type_disclaimer_date, cost, price_paid, notesstaff, notesopac. Test plan, k-t-d: 1) Install FreeForm and BLDSS backends, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-plus.sh) 2) Create a new FreeForm request, visit: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 5) Set type 'Book', put '42' in the cardnumber, and pick a library. Click 'create'. 6) Notice how there is a lot of unnecessary empty field entries 7) Apply patch, restart plack (koha-plack --restart kohadev) 8) Refresh the page, notice all the empty fields entries are no longer displayed Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This resolve at least a part of my Bug 36401 - Yay! :)
Pushed for 24.05! Well done everyone, thank you!
Not backported to 23.11.x