Unfortunately I have forgotten the details, but previously there was a way, perhaps by leaving CircAutoPrintQuickSlip empty, not to trigger an action when the checkouts form for a patron (at circ/circulation.pl?borrowernumber=xxxx) was submitting. Some recent change changed this behavior so that an action is always performed. This add a "do nothing" option to opt out of any action being taken.
*submitted
Created attachment 157800 [details] [review] Bug 35149: Add Option to ignore submit of checkout field when empty 1) Apply patch 2) Set CircAutoPrintQuickSlip to "do nothing" 3) Go to the checkouts form for a specific patron 4) Submit the form with empty value 5) Verify that no action is taken and you stay on the current page
Good idea. The CircAutoPrintQuickSlip sys pref is a 'choice' so I think we need a DB update and change to sysprefs.sql to reflect each choice.
Created attachment 162323 [details] [review] Bug 35149: Change CircAutoPrintQuickSlip syspref explanation
Thanks for the feedback, this should now be fixed.
Created attachment 163639 [details] [review] Bug 35149: Add Option to ignore submit of checkout field when empty 1) Apply patch 2) Set CircAutoPrintQuickSlip to "do nothing" 3) Go to the checkouts form for a specific patron 4) Submit the form with empty value 5) Verify that no action is taken and you stay on the current page Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Created attachment 163640 [details] [review] Bug 35149: Change CircAutoPrintQuickSlip syspref explanation Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Created attachment 166582 [details] [review] Bug 35149: Change CircAutoPrintQuickSlip syspref explanation Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
I remember this option as well, also: didn't we have "close patron account" as an option as well? (or do I just remember that from testing something else?)
(In reply to Katrin Fischer from comment #9) > I remember this option as well, also: didn't we have "close patron account" > as an option as well? (or do I just remember that from testing something > else?) Is that different than "Clear the screen"?
(In reply to Kyle M Hall from comment #10) > (In reply to Katrin Fischer from comment #9) > > I remember this option as well, also: didn't we have "close patron account" > > as an option as well? (or do I just remember that from testing something > > else?) > > Is that different than "Clear the screen"? No, you are correct. that makes sense! I was mostly justifying switching this to be a bug fix :)
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.06
Isn't installer/data/mysql/mandatory/sysprefs.sql missing choices of syspref CircAutoPrintQuickSlip ?
(In reply to Fridolin Somers from comment #14) > Isn't installer/data/mysql/mandatory/sysprefs.sql missing choices of syspref > CircAutoPrintQuickSlip ? I stumbled on this before, but it's been missing them before. Since we switched to YAML they are not actually used... so I didn't force the fix here.
Ah OK so legacy crap, no problem ;)
This seems like an enhancement and I won't backport it for 23.05.x