Bug 35149 - Add "do nothing" option to CircAutoPrintQuickSlip system preference
Summary: Add "do nothing" option to CircAutoPrintQuickSlip system preference
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: David Gustafsson
QA Contact: Kyle M Hall
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-25 13:39 UTC by David Gustafsson
Modified: 2024-05-30 19:15 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.06


Attachments
Bug 35149: Add Option to ignore submit of checkout field when empty (2.06 KB, patch)
2023-10-25 13:43 UTC, David Gustafsson
Details | Diff | Splinter Review
Bug 35149: Change CircAutoPrintQuickSlip syspref explanation (3.26 KB, patch)
2024-02-21 19:05 UTC, David Gustafsson
Details | Diff | Splinter Review
Bug 35149: Add Option to ignore submit of checkout field when empty (2.22 KB, patch)
2024-03-21 15:57 UTC, Laura Escamilla
Details | Diff | Splinter Review
Bug 35149: Change CircAutoPrintQuickSlip syspref explanation (3.33 KB, patch)
2024-03-21 15:57 UTC, Laura Escamilla
Details | Diff | Splinter Review
Bug 35149: Change CircAutoPrintQuickSlip syspref explanation (3.39 KB, patch)
2024-05-10 15:35 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Gustafsson 2023-10-25 13:39:06 UTC
Unfortunately I have forgotten the details, but previously there was a way, perhaps by leaving CircAutoPrintQuickSlip empty, not to trigger an action when the checkouts form for a patron (at circ/circulation.pl?borrowernumber=xxxx) was submitting. Some recent change changed this behavior so that an action is always performed. This add a "do nothing" option to opt out of any action being taken.
Comment 1 David Gustafsson 2023-10-25 13:39:35 UTC
*submitted
Comment 2 David Gustafsson 2023-10-25 13:43:22 UTC
Created attachment 157800 [details] [review]
Bug 35149: Add Option to ignore submit of checkout field when empty

1) Apply patch
2) Set CircAutoPrintQuickSlip to "do nothing"
3) Go to the checkouts form for a specific patron
4) Submit the form with empty value
5) Verify that no action is taken and you stay on the current page
Comment 3 Lucas Gass 2023-10-25 17:35:12 UTC
Good idea. The CircAutoPrintQuickSlip sys pref is a 'choice' so I think we need a DB update and change to sysprefs.sql to reflect each choice.
Comment 4 David Gustafsson 2024-02-21 19:05:24 UTC
Created attachment 162323 [details] [review]
Bug 35149: Change CircAutoPrintQuickSlip syspref explanation
Comment 5 David Gustafsson 2024-02-21 19:05:52 UTC
Thanks for the feedback, this should now be fixed.
Comment 6 Laura Escamilla 2024-03-21 15:57:22 UTC
Created attachment 163639 [details] [review]
Bug 35149: Add Option to ignore submit of checkout field when empty

1) Apply patch
2) Set CircAutoPrintQuickSlip to "do nothing"
3) Go to the checkouts form for a specific patron
4) Submit the form with empty value
5) Verify that no action is taken and you stay on the current page

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Comment 7 Laura Escamilla 2024-03-21 15:57:32 UTC
Created attachment 163640 [details] [review]
Bug 35149: Change CircAutoPrintQuickSlip syspref explanation

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Comment 8 Kyle M Hall 2024-05-10 15:35:28 UTC
Created attachment 166582 [details] [review]
Bug 35149: Change CircAutoPrintQuickSlip syspref explanation

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 9 Katrin Fischer 2024-05-10 15:49:34 UTC
I remember this option as well, also: didn't we have "close patron account" as an option as well? (or do I just remember that from testing something else?)
Comment 10 Kyle M Hall 2024-05-10 15:52:13 UTC
(In reply to Katrin Fischer from comment #9)
> I remember this option as well, also: didn't we have "close patron account"
> as an option as well? (or do I just remember that from testing something
> else?)

Is that different than "Clear the screen"?
Comment 11 Katrin Fischer 2024-05-10 15:53:49 UTC
(In reply to Kyle M Hall from comment #10)
> (In reply to Katrin Fischer from comment #9)
> > I remember this option as well, also: didn't we have "close patron account"
> > as an option as well? (or do I just remember that from testing something
> > else?)
> 
> Is that different than "Clear the screen"?

No, you are correct. that makes sense! I was mostly justifying switching this to be a bug fix :)
Comment 12 Katrin Fischer 2024-05-13 08:42:22 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 13 Fridolin Somers 2024-05-29 09:27:47 UTC
Pushed to 23.11.x for 23.11.06
Comment 14 Fridolin Somers 2024-05-29 09:32:28 UTC
Isn't installer/data/mysql/mandatory/sysprefs.sql missing choices of syspref CircAutoPrintQuickSlip ?
Comment 15 Katrin Fischer 2024-05-29 09:47:19 UTC
(In reply to Fridolin Somers from comment #14)
> Isn't installer/data/mysql/mandatory/sysprefs.sql missing choices of syspref
> CircAutoPrintQuickSlip ?

I stumbled on this before, but it's been missing them before. Since we switched to YAML they are not actually used... so I didn't force the fix here.
Comment 16 Fridolin Somers 2024-05-29 15:50:15 UTC
Ah OK so legacy crap, no problem ;)
Comment 17 Lucas Gass 2024-05-30 19:15:14 UTC
This seems like an enhancement and I won't backport it for 23.05.x