Bug 35173 - Call concat correctly for EDI SFTP Transport errors
Summary: Call concat correctly for EDI SFTP Transport errors
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Martin Renvoize
QA Contact: Kyle M Hall
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-27 10:45 UTC by Martin Renvoize
Modified: 2023-11-13 15:23 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.06,22.11.12


Attachments
Bug 35173: Correctly concat error strings (2.46 KB, patch)
2023-10-27 10:49 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35173: Correctly concat error strings (2.52 KB, patch)
2023-10-27 12:04 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2023-10-27 10:45:02 UTC
We are doing internal string concat within the EDI Transport module which results in 'Net::SFTP::Foreign=HASH(0x559c9118f0c8)->error' as apposed to the actual errors in the logs.
Comment 1 Martin Renvoize 2023-10-27 10:49:52 UTC
Created attachment 157978 [details] [review]
Bug 35173: Correctly concat error strings

This patch moves the call to $sftp->error outside of the double quote
string and into a . concat to properly expose the error message as
apposed to outputting 'Net::SFTP::Foreign=HASH(0x559c9118f0c8)->error'

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 2 Kyle M Hall 2023-10-27 12:04:24 UTC
Created attachment 157980 [details] [review]
Bug 35173: Correctly concat error strings

This patch moves the call to $sftp->error outside of the double quote
string and into a . concat to properly expose the error message as
apposed to outputting 'Net::SFTP::Foreign=HASH(0x559c9118f0c8)->error'

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 3 Tomás Cohen Arazi 2023-10-27 19:55:09 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 4 Fridolin Somers 2023-11-08 08:01:48 UTC
Pushed to 23.05.x for 23.05.06
Comment 5 Matt Blenkinsop 2023-11-13 15:23:34 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x