The header search form for circulation desks has an id attribute which is a duplicate of one on the desks entry form. That means that when you're adding a desk, clicking the "Desk name" label moves the cursor focus to the header search form instead of the field in the entry form.
Created attachment 158144 [details] [review] Bug 35205: Fix duplicate id attribute in desks search form This patch updates the header search form for desks administration so that it doesn't contain an HTML id attribute which duplicates one on the desks entry form. To test, apply the patch and make sure the "UseCirculationDesks" system preference is enabled. - Go to Administration -> Circulation desks -> New desk. - Click the "Desk" label in the entry form. Cursor focus should move to the adjacent input field. - Click the "Search desks" label in the header search form to confirm that your cursor moves to the header search form.
Created attachment 158227 [details] [review] Bug 35205: Fix duplicate id attribute in desks search form This patch updates the header search form for desks administration so that it doesn't contain an HTML id attribute which duplicates one on the desks entry form. To test, apply the patch and make sure the "UseCirculationDesks" system preference is enabled. - Go to Administration -> Circulation desks -> New desk. - Click the "Desk" label in the entry form. Cursor focus should move to the adjacent input field. - Click the "Search desks" label in the header search form to confirm that your cursor moves to the header search form. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 158391 [details] [review] Bug 35205: Fix duplicate id attribute in desks search form This patch updates the header search form for desks administration so that it doesn't contain an HTML id attribute which duplicates one on the desks entry form. To test, apply the patch and make sure the "UseCirculationDesks" system preference is enabled. - Go to Administration -> Circulation desks -> New desk. - Click the "Desk" label in the entry form. Cursor focus should move to the adjacent input field. - Click the "Search desks" label in the header search form to confirm that your cursor moves to the header search form. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Depends on Bug 34624 which added for="desk_name"
Pushed to 23.05.x for 23.05.06