Bug 35205 - Fix duplicate id attribute in desks search form
Summary: Fix duplicate id attribute in desks search form
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords: Sandbox
Depends on: 34624
Blocks:
  Show dependency treegraph
 
Reported: 2023-10-31 16:56 UTC by Owen Leonard
Modified: 2023-11-14 15:15 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.06


Attachments
Bug 35205: Fix duplicate id attribute in desks search form (2.28 KB, patch)
2023-10-31 17:04 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35205: Fix duplicate id attribute in desks search form (2.33 KB, patch)
2023-11-01 23:11 UTC, David Nind
Details | Diff | Splinter Review
Bug 35205: Fix duplicate id attribute in desks search form (2.39 KB, patch)
2023-11-04 17:50 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-10-31 16:56:33 UTC
The header search form for circulation desks has an id attribute which is a duplicate of one on the desks entry form. That means that when you're adding a desk, clicking the "Desk name" label moves the cursor focus to the header search form instead of the field in the entry form.
Comment 1 Owen Leonard 2023-10-31 17:04:47 UTC
Created attachment 158144 [details] [review]
Bug 35205: Fix duplicate id attribute in desks search form

This patch updates the header search form for desks administration so
that it doesn't contain an HTML id attribute which duplicates one on the
desks entry form.

To test, apply the patch and make sure the "UseCirculationDesks" system
preference is enabled.

- Go to Administration -> Circulation desks -> New desk.
- Click the "Desk" label in the entry form. Cursor focus should move to
  the adjacent input field.
- Click the "Search desks" label in the header search form to confirm
  that your cursor moves to the header search form.
Comment 2 David Nind 2023-11-01 23:11:18 UTC
Created attachment 158227 [details] [review]
Bug 35205: Fix duplicate id attribute in desks search form

This patch updates the header search form for desks administration so
that it doesn't contain an HTML id attribute which duplicates one on the
desks entry form.

To test, apply the patch and make sure the "UseCirculationDesks" system
preference is enabled.

- Go to Administration -> Circulation desks -> New desk.
- Click the "Desk" label in the entry form. Cursor focus should move to
  the adjacent input field.
- Click the "Search desks" label in the header search form to confirm
  that your cursor moves to the header search form.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2023-11-04 17:50:25 UTC
Created attachment 158391 [details] [review]
Bug 35205: Fix duplicate id attribute in desks search form

This patch updates the header search form for desks administration so
that it doesn't contain an HTML id attribute which duplicates one on the
desks entry form.

To test, apply the patch and make sure the "UseCirculationDesks" system
preference is enabled.

- Go to Administration -> Circulation desks -> New desk.
- Click the "Desk" label in the entry form. Cursor focus should move to
  the adjacent input field.
- Click the "Search desks" label in the header search form to confirm
  that your cursor moves to the header search form.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-11-06 11:40:45 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-11-10 07:17:01 UTC
Depends on Bug 34624 which added for="desk_name"
Comment 6 Fridolin Somers 2023-11-10 07:24:11 UTC
Pushed to 23.05.x for 23.05.06