Bug 35206 - Adjust style of add button on curbside pickups administration
Summary: Adjust style of add button on curbside pickups administration
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-31 17:09 UTC by Owen Leonard
Modified: 2024-07-04 20:40 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.06,22.11.12
Circulation function:


Attachments
Bug 35206: Adjust style of add button on curbside pickups administration (2.21 KB, patch)
2023-10-31 17:19 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35206: Adjust style of add button on curbside pickups administration (2.26 KB, patch)
2023-11-02 07:15 UTC, David Nind
Details | Diff | Splinter Review
Bug 35206: Adjust style of add button on curbside pickups administration (2.31 KB, patch)
2023-11-05 10:32 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-10-31 17:09:38 UTC
The "Add" button in the "Curbside pickup hours" section of the curbside pickups administration page looks too big. We can add Bootstrap classes to make it look more comfortable and consistent.
Comment 1 Owen Leonard 2023-10-31 17:19:27 UTC
Created attachment 158145 [details] [review]
Bug 35206: Adjust style of add button on curbside pickups administration

This patch adds Bootstrap classes to the "Add" button on the curbside
administration page, in the "Curbside pickup hours" section. This makes
it consistent with the markup of similar buttons in the interface and
makes it slightly smaller so that it fits better in the form.

To test, apply the patch and make sure the "CurbsidePickup" preference
is enabled.

- Go to Administration -> Curbside pickups.
- Fill out the form, including the "New slot" fields in the "Curbside
  pickup hours" section.
  - Confirm that the corresponding "Add" button looks correct, and that
    it works to add your new slot.
Comment 2 David Nind 2023-11-02 07:15:59 UTC
Created attachment 158230 [details] [review]
Bug 35206: Adjust style of add button on curbside pickups administration

This patch adds Bootstrap classes to the "Add" button on the curbside
administration page, in the "Curbside pickup hours" section. This makes
it consistent with the markup of similar buttons in the interface and
makes it slightly smaller so that it fits better in the form.

To test, apply the patch and make sure the "CurbsidePickup" preference
is enabled.

- Go to Administration -> Curbside pickups.
- Fill out the form, including the "New slot" fields in the "Curbside
  pickup hours" section.
  - Confirm that the corresponding "Add" button looks correct, and that
    it works to add your new slot.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2023-11-05 10:32:33 UTC
Created attachment 158443 [details] [review]
Bug 35206: Adjust style of add button on curbside pickups administration

This patch adds Bootstrap classes to the "Add" button on the curbside
administration page, in the "Curbside pickup hours" section. This makes
it consistent with the markup of similar buttons in the interface and
makes it slightly smaller so that it fits better in the form.

To test, apply the patch and make sure the "CurbsidePickup" preference
is enabled.

- Go to Administration -> Curbside pickups.
- Fill out the form, including the "New slot" fields in the "Curbside
  pickup hours" section.
  - Confirm that the corresponding "Add" button looks correct, and that
    it works to add your new slot.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-11-08 20:55:30 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-11-11 01:43:57 UTC
Small enhancement, I choose to backport.

Pushed to 23.05.x for 23.05.06
Comment 6 Pedro Amorim 2023-11-14 15:02:50 UTC
Nice work everyone!

Pushed to 22.11.x for next release