Bug 35215 - Make a few assumptions more explicit in Suggestions.t
Summary: Make a few assumptions more explicit in Suggestions.t
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Marcel de Rooy
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-01 15:14 UTC by Marcel de Rooy
Modified: 2023-11-14 15:15 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.06


Attachments
Bug 35215: Add few assumptions in Suggestions.t around emailing (1.61 KB, patch)
2023-11-01 15:23 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 35215: Add few assumptions in Suggestions.t around emailing (1.63 KB, patch)
2023-11-04 17:53 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2023-11-01 15:14:58 UTC
The test fails if you set a few preferences on your dev box. Or if you would have changed a few CPL branch columns.
Comment 1 Marcel de Rooy 2023-11-01 15:23:11 UTC
Created attachment 158177 [details] [review]
Bug 35215: Add few assumptions in Suggestions.t around emailing

Test plan:
Without this patch, set pref ReplytoDefault or EmailAddressForSuggestions.
Run t/db_dependent/Suggestions.t (FAIL)
Fill branch email and reply for CPL branch.
Run t/db_dependent/Suggestions.t (FAIL: more errors)
Apply patch.
Run t/db_dependent/Suggestions.t (PASS)

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2023-11-01 15:24:08 UTC
Trivial change in unit test: self SO.
Comment 3 Katrin Fischer 2023-11-04 17:53:57 UTC
Created attachment 158393 [details] [review]
Bug 35215: Add few assumptions in Suggestions.t around emailing

Test plan:
Without this patch, set pref ReplytoDefault or EmailAddressForSuggestions.
Run t/db_dependent/Suggestions.t (FAIL)
Fill branch email and reply for CPL branch.
Run t/db_dependent/Suggestions.t (FAIL: more errors)
Apply patch.
Run t/db_dependent/Suggestions.t (PASS)

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-11-06 11:40:52 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-11-10 07:26:13 UTC
Pushed to 23.05.x for 23.05.06