I think it makes sense to replace jquery.tablednd.js with DataTables "official" extension RowReorder: https://datatables.net/extensions/rowreorder/
Created attachment 163598 [details] [review] Bug 35249: Use DataTables RowReorder extension instead of tableDND jQuery plugin Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 163599 [details] [review] Bug 35249: Adjust table id and style We could eventually have a table for authorities, so better to have a specific table id. Also I think it's better to have the table smaller than taking the whole width Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 163600 [details] [review] Bug 35249: Remove tableDnD from the about page Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Talked with Owen and we wrote more or less the same patch (his was working however! Mine was missing the hidden column which didn't make the reorder works correctly).
Created attachment 163601 [details] [review] Bug 35249: Remove sort indicator on th
Created attachment 164795 [details] [review] Bug 35249: Use DataTables RowReorder extension instead of tableDND jQuery plugin Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 164796 [details] [review] Bug 35249: Adjust table id and style We could eventually have a table for authorities, so better to have a specific table id. Also I think it's better to have the table smaller than taking the whole width Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 164797 [details] [review] Bug 35249: Remove tableDnD from the about page Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 164798 [details] [review] Bug 35249: Remove sort indicator on th Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Fixed a conflict in the about page and followed-up on a QA script failure: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt FAIL forbidden patterns forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 12) forbidden pattern: Do *not* include full path to css files, use the Asset TT plugin (bug 20538) (line 12)
Pushed for 24.05! Well done everyone, thank you!
Not backported to 23.11.x