Bug 35251 - Issue table does not recalculate number of checkouts after a check in
Summary: Issue table does not recalculate number of checkouts after a check in
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 35068
Blocks: 35313
  Show dependency treegraph
 
Reported: 2023-11-03 15:32 UTC by Lucas Gass (lukeg)
Modified: 2024-07-04 20:37 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the number of checkouts shown on a patron's check-in and details page. Previously, if items were checked-in from either of these tabs, the number of checkouts was not updated.
Version(s) released in:
23.11.00
Circulation function:


Attachments
Bug 35251: Update checkout count when refreshing issue table (1.98 KB, patch)
2023-11-03 16:52 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 35251: Update checkout count when refreshing issue table (2.03 KB, patch)
2023-11-03 20:19 UTC, David Nind
Details | Diff | Splinter Review
Bug 35251: Update checkout count when refreshing issue table (2.08 KB, patch)
2023-11-05 18:43 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review
Bug 35251: Update checkout count when refreshing issue table (2.18 KB, patch)
2023-11-10 09:02 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2023-11-03 15:32:55 UTC
To recreate:

1. Have some checkouts 
2. Go to the issue-table and select some of those checkouts and check them in. 
3. Look at the tab, Checkouts(X)
4. This is not updated and now shows an incorrect number of checkouts.
Comment 1 Lucas Gass (lukeg) 2023-11-03 16:52:57 UTC
Created attachment 158355 [details] [review]
Bug 35251: Update checkout count when refreshing issue table

1. Have some checkouts
2. Go to the issue-table and select some of those checkouts and check them in.
3. Look at the tab, Checkouts(X)
4. This is not updated and now shows an incorrect number of checkouts.
4. APPLY PATCH, clear browser cache/
5. Try again, now when the table reloads the 'Checkouts(X)' tab should be correctly updated.
Comment 2 David Nind 2023-11-03 20:19:29 UTC
Created attachment 158367 [details] [review]
Bug 35251: Update checkout count when refreshing issue table

1. Have some checkouts
2. Go to the issue-table and select some of those checkouts and check them in.
3. Look at the tab, Checkouts(X)
4. This is not updated and now shows an incorrect number of checkouts.
4. APPLY PATCH, clear browser cache/
5. Try again, now when the table reloads the 'Checkouts(X)' tab should be correctly updated.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Victor Grousset/tuxayo 2023-11-05 18:43:12 UTC
Created attachment 158474 [details] [review]
Bug 35251: Update checkout count when refreshing issue table

1. Have some checkouts
2. Go to the issue-table and select some of those checkouts and check them in.
3. Look at the tab, Checkouts(X)
4. This is not updated and now shows an incorrect number of checkouts.
4. APPLY PATCH, clear browser cache/
5. Try again, now when the table reloads the 'Checkouts(X)' tab should be correctly updated.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 4 Victor Grousset/tuxayo 2023-11-05 19:22:36 UTC
Works, makes sense, QA script happy, code looks good :) Waiting for dependency to pass QA
Comment 5 Marcel de Rooy 2023-11-10 08:59:15 UTC
Looking here
Comment 6 Marcel de Rooy 2023-11-10 09:02:18 UTC
Created attachment 158793 [details] [review]
Bug 35251: Update checkout count when refreshing issue table

1. Have some checkouts
2. Go to the issue-table and select some of those checkouts and check them in.
3. Look at the tab, Checkouts(X)
4. This is not updated and now shows an incorrect number of checkouts.
4. APPLY PATCH, clear browser cache/
5. Try again, now when the table reloads the 'Checkouts(X)' tab should be correctly updated.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 7 Tomás Cohen Arazi (tcohen) 2023-11-10 14:02:37 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 8 Fridolin Somers 2023-11-11 07:50:57 UTC
Depends on Bug 35068 not in 23.05.x